Skip to content

Conversation

@ArcadeMode
Copy link
Owner

@ArcadeMode ArcadeMode commented Jan 14, 2026

add shims to change marshalling of chars to be strings instead of numbers.

Apparently char was indended to be represented as number (dotnet/runtime#123187) so it was a docs issue that string was mentioned as output type.
The end user most likely wants to work with strings when dealing with chars, so this PR is to do the simple transformations from number back to char.

  • render number types on interop boundary
  • convert to string in user api
  • add TS render tests
  • extend 'e2e' to get/set properties to test method interactions

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Test Results

349 tests   349 ✅  13s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 38e9ac9.

♻️ This comment has been updated with latest results.

@ArcadeMode ArcadeMode changed the title Marshall C# char as JS string Shims for C# char as JS string Jan 14, 2026
@ArcadeMode ArcadeMode changed the title Shims for C# char as JS string Shims for C# char as TS string Jan 14, 2026
@ArcadeMode ArcadeMode merged commit 5a4e209 into master Jan 17, 2026
2 checks passed
@ArcadeMode ArcadeMode deleted the char-marshalling branch January 17, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants