-
Notifications
You must be signed in to change notification settings - Fork 7
Fix redirects: add /en/ prefix to all redirect sources and destinations #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9ab87bc
fixes broken integration links
nearestnabors b9cd549
fixing borked redirects
nearestnabors dab5f2b
add localization to redirects
nearestnabors 9e73f1c
Fixing broken path sorter
nearestnabors 52a40a3
Fix redirects: add /en/ prefix to all redirect sources and destinations
nearestnabors 4636d27
Fix redirects
sdserranog 6f5140e
Update toolkit-utils.ts
sdserranog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mapToNewIA regex requires /en/ prefix that may be absent
The
mapToNewIAfunction's regex pattern^\/en\/mcp-servers\/...requires the input link to start with/en/mcp-servers/. Based on the PR discussion, the design system likely providesrelativeDocsLinkvalues without the/en/locale prefix since "the prefix should be added automatically." If the design system returns paths like/mcp-servers/productivity/gmail, the regex won't match and the original (potentially broken) link will be returned unchanged. The pattern may need to handle links both with and without the locale prefix.