Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# Pull request title

| Status | Type | Env Vars Change |
| :--------: | :---------------------------------: | :-------------: |
| Ready/Hold | Feature/Bug/Tooling/Refactor/Hotfix | Yes/No |

> ⚠️ NOTE: <OPTIONAL: use notes like this to emphasize something about the PR. This could include other PRs this PR is built on top of; reasons for why the PR is on hold; or anything else you would like to draw attention to.>

## Problem

<What problem are you trying to solve?>

- problem 1
- problem 2
....

## Solution

<How did you solve the problem?>

- solution 1
- solution 2
....

## Test results

<This can be a list of links to test results or a description of the tests run or some UI screenshots of the new/updated feature.
If don't found any data relate, give exactly instruction "_Add your screenshots or recording about testing_" instead of "**NEED FILL**">

## Other changes <e.g. bug fixes, UI tweaks, small refactors>

- change 1
- change 2
....

## Deploy Notes

<Notes regarding deployment of the contained body of work. These should note any new dependencies, new scripts, etc.
If no have new info, only show exactly "_There are no new dependencies, scripts, or environment variables introduced with this PR_">

<OPTIONAL: (IMPORTANT) delete this field if don't have new environment variables>
**New environment variables**:

- `env var` : env var details

<OPTIONAL: (IMPORTANT) delete this field if don't have new scripts>
**New scripts**:

- `script` : script (DB migrations, etc) details

<OPTIONAL: (IMPORTANT) delete this field if don't have new dependencies>
**New dependencies**:

- `dependency` : dependency details

<OPTIONAL: (IMPORTANT) delete this field if don't have new dev dependencies>
**New dev dependencies**:

- `dependency` : dependency details
73 changes: 73 additions & 0 deletions .github/instructions/PullRequest.instructions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
---
applyTo: '**'
---

Always ask for PR target branch(upstream), and the allowed targets branches are "development" and "main" branch
Always ask for the commits to be added to the PR in comma separated format and display the most reset commits using the following format:
`<commit id>: <commit title or message>`
Analyze the selected commits by id when generating the PR description
PR title must be a summary of all the selected commit messages with emoji
PR description must be generated as MD code snippet
Always Use the following template when generating PR(Pull Request) description

```md
# <Pull request title that best summaries the changes and the type of changes made with the appropriate emoji>

| Status | Type | Env Vars Change |
| :--------: | :---------------------------------: | :-------------: |
| Ready/Hold | Feature/Bug/Tooling/Refactor/Hotfix | Yes/No |

> ⚠️ NOTE: <OPTIONAL: use notes like this to emphasize something about the PR. This could include other PRs this PR is built on top of; reasons for why the PR is on hold; or anything else you would like to draw attention to.>

## Problem

<What problem are you trying to solve?>

- problem 1
- problem 2
....

## Solution

<How did you solve the problem?>

- solution 1
- solution 2
....

## Test results

<This can be a list of links to test results or a description of the tests run or some UI screenshots of the new/updated feature.
If don't found any data relate, give exactly instruction "_Add your screenshots or recording about testing_" instead of "**NEED FILL**">

## Other changes <e.g. bug fixes, UI tweaks, small refactors>

- change 1
- change 2
....

## Deploy Notes

<Notes regarding deployment of the contained body of work. These should note any new dependencies, new scripts, etc.
If no have new info, only show exactly "_There are no new dependencies, scripts, or environment variables introduced with this PR_">

<OPTIONAL: (IMPORTANT) delete this field if don't have new environment variables>
**New environment variables **:

- `env var` : env var details

<OPTIONAL: (IMPORTANT) delete this field if don't have new scripts>
**New scripts**:

- `script` : script (DB migrations, etc) details

<OPTIONAL: (IMPORTANT) delete this field if don't have new dependencies>
**New dependencies**:

- `dependency` : dependency details

<OPTIONAL: (IMPORTANT) delete this field if don't have new dev dependencies>
**New dev dependencies**:

- `dependency` : dependency details
```
8 changes: 5 additions & 3 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: Verify

env:
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}

on:
push:
branches:
Expand All @@ -18,9 +21,6 @@ jobs:
fetch-depth: 0

- uses: pnpm/action-setup@v4
with:
version: 9

# Cache node_modules
- uses: actions/setup-node@v4
with:
Expand All @@ -34,3 +34,5 @@ jobs:
# - run: pnpm exec nx-cloud record -- echo Hello World
# Nx Affected runs only tasks affected by the changes in this PR/commit. Learn more: https://nx.dev/ci/features/affected
- run: pnpx nx affected -t build && pnpm build
- run: npx nx fix-ci
if: always()
4 changes: 1 addition & 3 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
"nrwl.angular-console",
"stringham.move-ts",
"pmneo.tsimporter",
"wallabyjs.quokka-vscode",
"wallabyjs.console-ninja",
"antfu.vite",
"mhutchie.git-graph",
"shardulm94.trailing-spaces",
Expand All @@ -37,4 +35,4 @@
"github.vscode-github-actions",
"ms-playwright.playwright"
]
}
}
13 changes: 12 additions & 1 deletion nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,17 @@
"build": {
"dependsOn": [
"^build",
"minify",
"lint"
],
"outputs": [
"{projectRoot}/dist"
],
"cache": true
},
"minify": {
"dependsOn": [
"^minify",
"lint"
],
"outputs": [
Expand All @@ -29,5 +40,5 @@
"sharedGlobals"
]
},
"nxCloudId": "681f1bf43845db51336764b6"
"nxCloudId": "66b806726340ec37c5b8ec1b"
}
Loading