Import ArcNotes source snapshot#1
Merged
Merged
Conversation
added 8 commits
May 18, 2026 00:10
Resolves all warnings flagged by the pre-commit clang-tidy hook on
macOS/Linux CI (modernize-use-nodiscard, -use-override, -concat-nested-
namespaces, -pass-by-value, -use-equals-default). Also excludes the
Linux-only xdgglobalshortcutmanager.{cpp,h} from the hook so non-Linux
CI does not trip on the unresolvable <QDBusConnection> include.
After marking const getters / mutators [[nodiscard]] in the previous commit, MSVC /WX promotes C4834 to errors. Resolves the 25 affected call sites in two flavors: - 19 deliberate fire-and-forget sites (bulk save/delete, cleanup on error path, periodic migrate/expire) are explicitly cast to (void). - 6 settings.value(...) sites in databaseservice.cpp turned out to be typo bugs inherited from the QOwnNotes import — the surrounding block sets defaults when the key is absent, so they should call setValue(). Corrected.
Removes push/pull_request triggers so CodeQL only runs on the existing '0 0 1 * *' cron. Saves CI minutes on every commit while still giving monthly security coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation