chore: fix clangd config for multi-root workspace#18
Merged
Conversation
Move --compile-commands-dir from VS Code settings (window-scoped, not applicable per-folder in multi-root) into .clangd config file. clangd's CompileFlags.CompilationDatabase resolves relative to each project root, achieving the same per-project path resolution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves clangd configuration out of VS Code workspace settings into a repo-wide .clangd file, aiming to make clangd setup editor-agnostic while keeping the compilation database location consistent.
Changes:
- Removed
clangd.argumentsfrom.vscode/settings.json. - Added a root
.clangdfile to point clangd atbuild/forcompile_commands.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.vscode/settings.json |
Removes VS Code-specific clangd argument configuration. |
.clangd |
Adds a clangd config to set the compilation database directory to build/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ClangTidy: true is not valid clangd config (expects a dict, not bool). clang-tidy is enabled via --clang-tidy in Arc.code-workspace and reads .clang-tidy automatically; no extra .clangd entry needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
clangd.argumentswarning in VS Code multi-root workspace.Problem
clangd.argumentsis a window-scoped VS Code setting and cannot be applied in a per-folder.vscode/settings.jsonwhen using a multi-root workspace. VS Code shows:Solution
.clangdconfig file withCompileFlags.CompilationDatabase: buildto handle per-project compile commands pathclangd.arguments(non path-specific flags) are now set at the workspace level inArc.code-workspaceclangd.argumentsfrom.vscode/settings.json