Skip to content

Step NC03: Desktop App Shell And Theme#10

Merged
deku2026 merged 11 commits into
mainfrom
codex/nc03-desktop-app-shell-and-theme
May 22, 2026
Merged

Step NC03: Desktop App Shell And Theme#10
deku2026 merged 11 commits into
mainfrom
codex/nc03-desktop-app-shell-and-theme

Conversation

@deku2026
Copy link
Copy Markdown
Contributor

Summary

  • Implements Step NC03: Desktop App Shell And Theme
  • Keeps scope limited to the active step
  • Updates traceability and acceptance evidence required by the step

Verification

  • $env:MSBUILDDISABLENODEREUSE='1'; dotnet restore ArcChat.slnx -m:1: passed
  • $env:MSBUILDDISABLENODEREUSE='1'; dotnet build ArcChat.slnx -m:1 --no-restore: passed
  • $env:MSBUILDDISABLENODEREUSE='1'; dotnet test ArcChat.slnx -m:1 --no-build --blame-hang-timeout 120s: passed
  • $env:MSBUILDDISABLENODEREUSE='1'; dotnet test apps\desktop\ArcChat.Desktop.UiTests\ArcChat.Desktop.UiTests.csproj -m:1 --no-build --blame-hang-timeout 120s: passed
  • $env:MSBUILDDISABLENODEREUSE='1'; dotnet test desktop-shared\ArcChat.UI.Theme.Tests\ArcChat.UI.Theme.Tests.csproj -m:1 --no-build --blame-hang-timeout 120s: passed
  • $env:MSBUILDDISABLENODEREUSE='1'; dotnet test desktop-shared\ArcChat.UI.Controls.Tests\ArcChat.UI.Controls.Tests.csproj -m:1 --no-build --blame-hang-timeout 120s: passed
  • $env:MSBUILDDISABLENODEREUSE='1'; dotnet format ArcChat.slnx --verify-no-changes --no-restore: passed
  • $env:MSBUILDDISABLENODEREUSE='1'; pwsh -NoLogo -NoProfile -ExecutionPolicy Bypass -File scripts\verify-notice.ps1: passed
  • $env:MSBUILDDISABLENODEREUSE='1'; dotnet run --project apps\desktop\ArcChat.Desktop --no-build: boot smoke stayed alive for 5 seconds, then stopped

Traceability

  • Rows updated: NC-UI-001, NC-UI-002, NC-UI-003, NC-UI-004, NC-UI-005, NC-UI-006, NC-UI-007, NC-FEAT-024, NC-FEAT-025
  • Matrices updated: docs/coverage/nc03-desktop-shell-theme.md, docs/coverage/settings-schema.md, docs/coverage/visual-baseline/README.md
  • Final-gate impact: NC03 shell/theme accessibility, visual baseline, locale/theme runtime switching, and settings evidence are now covered by tests and reproducible artifacts

Out Of Scope

  • Conversation feature (NC04)
  • Providers (NC05/NC06)
  • Masks/plugins beyond shell placeholders (NC07)

Open Questions

  • None

Comment thread apps/desktop/ArcChat.Desktop.UiTests/AccessibilityBaselineTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/AccessibilityBaselineTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/MainWindowTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/MainWindowTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/MainWindowTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/MainWindowTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/MainWindowTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/MainWindowTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/SettingsViewTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/VisualBaselineTests.cs Fixed
@deku2026 deku2026 marked this pull request as ready for review May 22, 2026 20:27
Comment thread apps/desktop/ArcChat.Desktop.UiTests/AccessibilityBaselineTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop/Localization/LocaleService.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop/Localization/LocaleService.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/LocaleServiceTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/LocaleServiceTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/LocaleServiceTests.cs Fixed
Comment thread apps/desktop/ArcChat.Desktop.UiTests/LocaleServiceTests.cs Fixed
@deku2026 deku2026 merged commit 457d3e8 into main May 22, 2026
6 checks passed
@deku2026 deku2026 deleted the codex/nc03-desktop-app-shell-and-theme branch May 22, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant