Skip to content

Conversation

@yphil-dev
Copy link
Contributor

No description provided.

@yphil-dev
Copy link
Contributor Author

yphil-dev commented Dec 5, 2025

Hi @probonopd

I don't get the whole app add sequence.

  • add [app_name] URL to data/[app_name] ; Create PR
  • 1st CI run:test
    • DL AppImage file
    • Lint
    • Try to get a screenshot in firejail
  • Merge PR
  • 2nd CI run :
    • maybe get a screenshot URL in the AppStream file
    • maybe get an AppStream XML file in /usr/share/metainfo/[app_id].appdata.xml
    • generate the apps/[app_name].md file
    • and also the icon file

Is that OK?

Shouldn't the screenshot thing be done in one pass? As in "Screenshot = valid URL in /usr/share/metainfo/[app_name].appdata.xml.screenshot" || firejail lousy screenshot..?

In any case, thanks for your patience.

@probonopd
Copy link
Member

Yes, this is roughly how it should work: While it is still a PR, we run the test and screenshot to see whether it works. Once merged, the whole thing gets run again and the created files are then deployed to the web server.

@probonopd probonopd merged commit 3fad6a2 into AppImage:master Dec 6, 2025
1 check passed
@probonopd
Copy link
Member

Seems like 8cc929e has done the trick. Don't know why the first one didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants