Skip to content

Deprecated preferences #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannesa2 merged 1 commit into from
Jan 25, 2026
Merged

Deprecated preferences #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions ChangeLogLib/src/main/java/info/hannes/changelog/ChangeLog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ package info.hannes.changelog

import android.app.AlertDialog
import android.content.Context
import android.content.Context.MODE_PRIVATE
import android.content.SharedPreferences
import android.content.pm.PackageManager.NameNotFoundException
import android.os.Build
import android.os.Handler
import android.os.Looper
import android.preference.PreferenceManager
import android.util.Log
import android.util.SparseArray
import androidx.core.util.size
Expand All @@ -29,7 +29,7 @@ import java.util.Collections
*/
open class ChangeLog @JvmOverloads constructor(
private val context: Context,
preferences: SharedPreferences = PreferenceManager.getDefaultSharedPreferences(context),
preferences: SharedPreferences = context.getSharedPreferences(PREFERENCES_NAME, MODE_PRIVATE),
protected val css: String = DEFAULT_CSS,
val callback: (() -> Unit)? = null
) {
Expand Down Expand Up @@ -153,7 +153,11 @@ open class ChangeLog @JvmOverloads constructor(
* @param context Context that is used to access the resources and to create the ChangeLog dialogs.
* @param css CSS styles that will be used to format the change log.
*/
constructor(context: Context, css: String) : this(context, PreferenceManager.getDefaultSharedPreferences(context), css) {}
constructor(context: Context, css: String) : this(
context = context,
preferences = context.getSharedPreferences(PREFERENCES_NAME, MODE_PRIVATE),
css = css
)

init {
try {
Expand Down Expand Up @@ -228,7 +232,8 @@ open class ChangeLog @JvmOverloads constructor(
* Write current version code to the preferences.
*/
protected fun updateVersionInPreferences() {
val sp = PreferenceManager.getDefaultSharedPreferences(context)

val sp = context.getSharedPreferences(PREFERENCES_NAME, MODE_PRIVATE)
val editor = sp.edit()
editor.putInt(VERSION_KEY, currentVersionCode)
editor.apply()
Expand Down Expand Up @@ -458,19 +463,10 @@ open class ChangeLog @JvmOverloads constructor(
"li { margin-left: 0px; }" + "\n" +
"ul { padding-left: 2em; }"

/**
* Tag that is used when sending error/debug messages to the log.
*/
private const val LOG_TAG = "ChangeLog"

/**
* This is the key used when storing the version code in SharedPreferences.
*/
protected const val VERSION_KEY = "ChangeLog_last_version_code"

/**
* Constant that used when no version code is available.
*/
protected const val NO_VERSION = -1
const val VERSION_KEY = "ChangeLog_last_version_code"
const val NO_VERSION = -1
const val PREFERENCES_NAME = "changelog"
}
}
Loading