Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 654000c from v4.5.12 introduced a regression in the scheduler loop. As reported on Discord by xtalker:
The commit mentioned above introduced a debug logging statement in the scheduler loop that assumes all callbacks are non-None function objects. However, timeout/cancellation entries are legitimately None. These entries are created when callbacks have
timeoutparameters and are used to cancel other callbacks (state, event, or log callbacks) when they expire.The bug manifests after several hours because timeout entries only trigger when their scheduled event arrives.
The Fix
Added a None check before accessing the callback's
__name__attribute:A similar fix was applied to the schedule display function to prevent the same error when viewing scheduled callbacks.