only clean query parameters #2475
Merged
+23
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
cebtenzzre
commented
Nov 30, 2025
appdaemon/utils.py
Outdated
Comment on lines
1176
to
1180
| return result.strip("/") | ||
| parsed = parse.urlparse(str(base)) | ||
| result = parsed._replace(path=endpoint) | ||
| return parse.urlunparse(result) |
Contributor
Author
There was a problem hiding this comment.
I think this breaks base URLs with a path (e.g. http://supervisor/core) - it will replace /core with the endpoint path instead of appending. See #2485 for a better fix using yarl.
We need a serializer for all fields in the model.
We prefix paths like `/api/states` with a slash even though they're relative in practice, not absolute. It's simpler to always append to the path and lstrip the leading slash from the endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to "clean" the json body of a POST request to alter things like booleans - JSON already has a way to represent them. That wasn't done in 4.4.x, which had a more transparent set_state.
One possible exception is datetime, which doesn't have one true JSON representation. But we can enhance convert_json to always use isoformat.
(Also, DELETE shouldn't have a body - but it may have query params. We don't currently use kwargs with DELETE so this isn't crucial, but it's important for correctness.)
Fixes #2464