Fix Windows system-path detection and make CLI help assertions robust#7
Merged
AperturePlus merged 1 commit intodevelopfrom Feb 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
C:\Program Files (x86).Description
_is_windows_system_directoryinsrc/aci/core/path_utils.pyto normalize the first Windows path part usingrstrip("\\/")before matching drive letters so drive roots are stripped reliably.tests/unit/test_cli.pyby removing ANSI escape sequences from command output and asserting on stable tokens (workers,limit,filter,-w) instead of exact long-option rendering.Testing
_is_windows_system_directorywithPath(r"C:\\Program Files (x86)")which returnedTrueas expected.pytest tests/unit/test_cli.py::TestCLIHelp::test_index_help tests/unit/test_cli.py::TestCLIHelp::test_search_help -qand both tests passed.hypothesis(error:ModuleNotFoundError: No module named 'hypothesis'), so full property-suite verification could not be completed here.Codex Task