react to OS theme changes in real time#28
Merged
Conversation
Subscribe to prefers-color-scheme changes when theme=system so the dashboard re-themes immediately, instead of only on initial load. Closes #27
There was a problem hiding this comment.
Pull request overview
Adds real-time OS theme change handling to the main dashboard when the user’s theme preference is set to system, so the UI updates immediately without requiring a reload.
Changes:
- Replaces the simple “apply theme on theme change” effect with a
prefers-color-schemesubscription that’s only active whentheme === "system". - Cleans up the media query listener on effect teardown to avoid leaking listeners across renders.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+96
to
+101
|
|
||
| useEffect(() => { | ||
| applyTheme(theme); | ||
| if (theme !== "system") return; | ||
| const mql = window.matchMedia("(prefers-color-scheme: dark)"); | ||
| const onChange = () => applyTheme(theme); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27.
Subscribe to
prefers-color-schemechanges whentheme=systemso thedashboard re-themes immediately, instead of only on initial load.
Test plan