Skip to content

Cleanup and define consistent pattern for leap plugin startup/shutdown. #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
greg7mdp wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Cleanup and define consistent pattern for leap plugin startup/shutdown. #1231

greg7mdp wants to merge 24 commits into from

Conversation

@greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Jun 5, 2023

greg7mdp added 12 commits May 25, 2023 11:13
@greg7mdp
use appbase branch which calls plugin_shutdown() on exception.
ee4e4b0
@greg7mdp
update appbase to new tip
ee29899
@greg7mdp
Do not destroy chain::controller on plugin_shutdown().
3812d5b 
as other plugins could possibly not be shutdown yet.
@greg7mdp
No need to catch exceptions to make sure plugin_shutdown() is execu…
3210dfe 
…ted.

This is now ensured with the current version of appbase.
@greg7mdp
Whitespace fix
81e5a81
@greg7mdp
In plugin_startup(), in case of error, better throw than call `ap…
a2157c4 
…p().quit()`
@greg7mdp
Merge branch 'main' of github.com:AntelopeIO/leap into gh-672
97aa420
@greg7mdp
Remove unnecessary (now) try/catch block calling plugin_shutdown()
dc72da4
@greg7mdp
Merge branch 'main' of github.com:AntelopeIO/leap into gh-672
a35e793
@greg7mdp
Add usage_patterns.md file
a4f54a2
@greg7mdp
Merge branch 'main' of github.com:AntelopeIO/leap into gh-672
2bd8818
@greg7mdp
Merge branch 'main' of github.com:AntelopeIO/leap into gh-672
4869d63
@greg7mdp greg7mdp marked this pull request as draft June 5, 2023 20:19
@greg7mdp
Copy link
Contributor Author

greg7mdp commented Jun 5, 2023 •
edited
Loading

Hey @spoonincode , can you have a look at my current changes, and at this document I wrote describing my current thoughts on what we should do? Looking for any input you may have. Thanks!

@arhag arhag linked an issue Jun 22, 2023 that may be closed by this pull request
Improve Nodeos Plugin Shutdown Patterns #1099
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cleanup and define consistent pattern for handling nodeos plugin shutdown Improve Nodeos Plugin Shutdown Patterns

2 participants

@greg7mdp