Skip to content

feat: auth + query emissions-due (replay of pr28)#2

Open
antfleet-ops wants to merge 1 commit into
mainfrom
replay/pr28-auth
Open

feat: auth + query emissions-due (replay of pr28)#2
antfleet-ops wants to merge 1 commit into
mainfrom
replay/pr28-auth

Conversation

@antfleet-ops
Copy link
Copy Markdown
Contributor

Replay of Reppo-Labs/reppo-cli#28 — authentication flow + emissions-due query (auth/API surface).

@antfleet
Copy link
Copy Markdown

antfleet Bot commented May 25, 2026

AntFleet · 1 finding

Both reviewers flagged the items below on the changed files. AntFleet posts only what two independent frontier models agree on.


Docs-gap · Low — Comment in db.ts claims session schema has agentId, but persisted sessions for reppo-platform never carry one
src/state/db.ts:8-12

The schema docstring lists agentId as a top-level session field, suggesting it's always present. In practice the SessionEntry stored by signInWithEthereum only contains accessToken/walletAddress/expiresAt/createdAt — no agentId. The interface marks agentId optional, so the docstring is misleading. Minor but worth aligning to prevent agents that read the source for guidance from expecting agentId.

Fix: Update the schema comment to mark agentId/expiresAt as optional, mirroring the interface.

Proposed patch (model: claude-opus-4-7)
 *       agentId?: string,    // optional; not set by reppo-platform SIWE flow
 *       expiresAt?: number,  // optional; depends on auth provider

Review 7284403c · claude-opus-4-7 + gpt-5 (unanimous) · 253s · ~$0.40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant