Lab8 #6
Open
Lab8 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soamid
commented
Dec 7, 2022
Collaborator
Author
Soamid
left a comment
Soamid
left a comment
There was a problem hiding this comment.
Ocena za lab: 1.8 / 2
| private final IWorldMap map; | ||
| private final Vector2d[] animalsVectors; | ||
| private final List<Animal> animalsOnMap = new ArrayList<>(); | ||
| protected AppVisualizer appVisualizer; |
Collaborator
Author
There was a problem hiding this comment.
tej zależności zdecydowanie nie chcemy, właśnie po to nam observer żeby uniknąć sytuacji gdy engine musi znać GUI. Wystarczyłoby żeby konstruktor przyjmował go jako IPositionChangeObserver i nie zapisywał tego w atrybucie nawet, tylko rejestrował od razu w zwierzątkach.
| this.appVisualizer = appVisualizer; | ||
| this.moveDelay = moveDelay; | ||
| } | ||
| public SimulationEngine(IWorldMap map, Vector2d[] animalsVectors, AppVisualizer appVisualizer, int moveDelay){ |
Collaborator
Author
There was a problem hiding this comment.
te konstruktory są ryzykowne - zawsze powinniśmy zwijać jeden w drugi od najmniejszego do największego. Obecnie np. będziemy próbowali dodać nullowy visualizer jeśli użyjemy pierwszego konstruktora.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.