feat: added new property buttonLayout for vertical layout for edit/delet buttons#4179
Hidden character warning
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds support for vertical button layout in repeating group tables by introducing a new ChangesVertical Button Layout for Repeating Group Tables
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
buttonLayout for vertical layout
buttonLayout for vertical layoutbuttonLayout for vertical layout for edit/delet buttons
walldenfilippa
left a comment
There was a problem hiding this comment.
Good job! I noticed that the buttons weren’t fully aligned, so I made a suggestion on how to fix it 🙂
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/layout/RepeatingGroup/Table/RepeatingGroupTable.tsx`:
- Around line 151-161: The header cell currently always renders visually hidden
labels for both edit and delete which misleads screen readers; in
RepeatingGroupTable (look for useVerticalButtonLayout, columnCount,
displayEditColumn, displayDeleteColumn and utilClasses.visuallyHidden) change
the JSX so each visually-hidden <Lang id='general.edit'/> and <Lang
id='general.delete'/> is conditionally rendered only when its corresponding flag
(displayEditColumn or displayDeleteColumn) is true, leaving the surrounding
Table.HeaderCell rendering logic unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 811377f7-f9c2-4635-a530-5ae16f3d1d01
📒 Files selected for processing (4)
src/layout/RepeatingGroup/Table/RepeatingGroupTable.test.tsxsrc/layout/RepeatingGroup/Table/RepeatingGroupTable.tsxsrc/layout/RepeatingGroup/Table/RepeatingGroupTableRow.tsxsrc/layout/RepeatingGroup/config.ts
|
walldenfilippa
left a comment
There was a problem hiding this comment.
Looks good! 🥳
I noticed that -webkit-baseline-middle does not work perfectly with all browsers in RepeatingGroup.module.css.
Eg. edge:

By changing vertical-align: -webkit-baseline-middle; to vertical-align: middle in RepeatingGroup.module.css the component values are placed in the middle in all browsers.
**Edge:

This is outside of this scope, but since it is a small fix, maybe we can include it here? What do you think?
Ah, good catch! |
|
✅ Automatic backport successful! A backport PR has been automatically created for the The release branch The cherry-pick was clean with no conflicts. Please review the backport PR when it appears. |
…delet buttons (#4179) * perf: added new optional property layoutButton for vertical layout * refactor * fix coderabbitai feedback










Description
This PR adds a new optional
edit.buttonLayoutproperty to RepeatingGroup so table row buttons can be arranged either horizontally (default) or vertically.When set to
"vertical",editanddeletebuttons are rendered in a single column, which saves horizontal space in tables.What changed
- Allowed values:
"horizontal" | "vertical"- Default:"horizontal"- two columns in horizontal mode
- one combined action column in vertical mode
Related Issue(s)
closes Repeterende gruppe: Rediger-knappen tar veldig mye plass på tabeller med
editInTable: true. #4125doce PR
Screen.Recording.2026-05-07.at.10.29.43.mov
Verification/QA
kind/*andbackport*label to this PR for proper release notes groupingSummary by CodeRabbit
New Features
Tests