test: MongoDB normalizeConfig aliases — close coverage gap from #482

[anandgupta42]

What does this PR do?

1. normalizeConfig — MongoDB aliases in packages/drivers/src/normalize.ts (8 new tests)

MongoDB driver support was added in #482, but driver-normalize.test.ts had zero tests for the MONGODB_ALIASES map. Every other driver (Postgres, Snowflake, BigQuery, Databricks, SQL Server, Oracle, MySQL) had alias normalization tests — MongoDB was the only gap.

Why it matters: Users configure MongoDB connections using field names from the MongoDB Node.js driver docs (connectionString), mongosh docs (uri), or the native driver options (authSource, replicaSet, directConnection, connectTimeoutMS). Without normalization working correctly, these camelCase/alternative names silently fail — the driver doesn't see the connection string and falls back to constructing a URI from host/port, causing connection failures or connecting to the wrong database.

Specific scenarios covered:

• connectionString → connection_string (MongoDB Node.js driver convention)
• uri → connection_string (mongosh / pymongo convention)
• authSource → auth_source (driver option)
• replicaSet → replica_set (driver option)
• directConnection → direct_connection (driver option, boolean)
• connectTimeoutMS → connect_timeout (driver option, number)
• mongo type alias routes to MongoDB alias map (not just mongodb)
• Canonical MongoDB config passes through unchanged (regression guard)

What was intentionally excluded (critic review):

• Common aliases (username → user, dbname → database) — already tested for other drivers via the shared COMMON_ALIASES object
• url → connection_string — same code path as uri, no additional coverage
• detectAuthMethod MongoDB branch — critic analysis showed the branch is shadowed by prior guards; proposed tests would pass for wrong reasons

Type of change

• New feature (non-breaking change which adds functionality)

Issue for this PR

N/A — proactive test coverage for #482

How did you verify your code works?

bun test test/altimate/driver-normalize.test.ts    # 86 pass (78 existing + 8 new)

Checklist

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

https://claude.ai/code/session_01AhNUh22SS3cRR9GVNiTcit

Summary by CodeRabbit

• Tests
  • Added comprehensive test coverage for MongoDB configuration normalization, including field alias mapping and type alias routing verification.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A new test suite for MongoDB config normalization was added, covering alias conversion for MongoDB-specific fields (connectionString, authSource, replicaSet, directConnection, connectTimeoutMS) to their snake_case equivalents, and verifying that pre-normalized canonical configs remain unchanged.

Changes

Cohort / File(s)	Summary
MongoDB Config Normalization Tests packages/opencode/test/altimate/driver-normalize.test.ts	Added comprehensive test suite verifying MongoDB field alias normalization (camelCase → snake_case), "mongo" type alias registration, and idempotent handling of already-normalized configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• feat: add MongoDB driver support #482: Implemented the normalize.ts driver with MongoDB alias mappings and "mongo"/"mongodb" type registration that these tests directly validate.

Poem

🐰 A rabbit hops through test cases true,
MongoDB fields in snake_case hue,
Aliases dance from camel to snake,
No mutations left in its wake,
Config normalized—perfect and bright!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding MongoDB normalizeConfig alias tests to close a coverage gap from issue #482.
Description check	✅ Passed	The description comprehensively covers all required template sections: Summary (what changed and why), Test Plan (verification with bun test output), and Checklist (tests added and unit tests passing).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/hourly-20260327-0608

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

packages/opencode/test/altimate/driver-normalize.test.ts (1)

667-747: Consider adding a test for serverSelectionTimeoutMS → server_selection_timeout.

MONGODB_ALIASES also defines serverSelectionTimeoutMS, and this one is a distinct mapping (not a duplicate-path alias like uri/url). Adding one test would close the remaining MongoDB-specific alias gap.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/opencode/test/altimate/driver-normalize.test.ts` around lines 667 -
747, Add a test exercising the serverSelectionTimeoutMS →
server_selection_timeout alias: call normalizeConfig with { type: "mongodb",
serverSelectionTimeoutMS: 30000 } and assert the returned object has
server_selection_timeout === 30000 and serverSelectionTimeoutMS is undefined;
place this alongside the other MongoDB alias tests in the
describe("normalizeConfig — MongoDB") block so the mapping defined in
MONGODB_ALIASES is covered.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/opencode/test/altimate/driver-normalize.test.ts`:
- Around line 667-747: Add a test exercising the serverSelectionTimeoutMS →
server_selection_timeout alias: call normalizeConfig with { type: "mongodb",
serverSelectionTimeoutMS: 30000 } and assert the returned object has
server_selection_timeout === 30000 and serverSelectionTimeoutMS is undefined;
place this alongside the other MongoDB alias tests in the
describe("normalizeConfig — MongoDB") block so the mapping defined in
MONGODB_ALIASES is covered.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 85cc108b-3e3f-4ac5-bcd0-4dabc3e13ba1

📥 Commits

Reviewing files that changed from the base of the PR and between abcaa1d and 9d01e38.

📒 Files selected for processing (1)

• packages/opencode/test/altimate/driver-normalize.test.ts

[anandgupta42]

Consolidated into #514. This PR's test coverage was either already on main or has been included in the consolidated PR.