Skip to content

Optimize Pulp upload: exponential backoff, reuse SHA256, fix size threshold #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anfimovdm merged 1 commit into from
Mar 5, 2026
Merged

Optimize Pulp upload: exponential backoff, reuse SHA256, fix size threshold #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sign_node/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
DEFAULT_PULP_PASSWORD = "test_pwd"
DEFAULT_PULP_CHUNK_SIZE = 8388608 # 8 MiB
# Max file size to allow parallel upload for
DEFAULT_PARALLEL_FILE_UPLOAD_SIZE = 52428800 # 500 MB
DEFAULT_PARALLEL_FILE_UPLOAD_SIZE = 524288000 # 500 MB
DEFAULT_PGP_PASSWORD = "test_pwd"
DEFAULT_SENTRY_DSN = ""
DEFAULT_SENTRY_ENVIRONMENT = "dev"
Expand Down
13 changes: 7 additions & 6 deletions sign_node/uploaders/pulp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ def _wait_for_task_completion(self, task_href: str) -> dict:

"""
result = self._tasks_client.read(task_href)
delay = 0.3
while result.state not in ("failed", "completed"):
time.sleep(5)
time.sleep(delay)
delay = min(delay * 2, 5)
result = self._tasks_client.read(task_href)
if result.state == "failed":
raise TaskFailedError(f"task {task_href} has failed, " f"details: {result}")
Expand All @@ -113,25 +115,24 @@ def _create_upload(self, file_path: str) -> (str, int):
response = self._uploads_client.create({"size": file_size})
return response.pulp_href, file_size

def _commit_upload(self, file_path: str, reference: str) -> str:
def _commit_upload(self, reference: str, file_sha256: str) -> str:
"""
Commits upload and waits until upload will be transformed to artifact.
Returns artifact reference upon completion.

Parameters
----------
file_path : str
Path to the file.
reference : str
Upload reference in Pulp.
file_sha256 : str
Pre-computed SHA256 of the file.

Returns
-------
str
Reference to the created resource.

"""
file_sha256 = hash_file(file_path, hash_type="sha256")
response = self._uploads_client.commit(reference, {"sha256": file_sha256})
task_result = self._wait_for_task_completion(response.task)
return task_result.created_resources[0]
Expand Down Expand Up @@ -167,7 +168,7 @@ def _send_file(self, file_path: str) -> typing.Tuple[str, str]:
self._uploads_client.update(
f"bytes 0-{file_size - 1}/{file_size}", reference, file_path
)
artifact_href = self._commit_upload(file_path, reference)
artifact_href = self._commit_upload(reference, file_sha256)
return file_sha256, artifact_href

def check_if_artifact_exists(self, sha256: str) -> str:
Expand Down
Loading