Skip to content

fix: allow subject/procedures 400 responses, expose error messages, fix typo#159

Merged
dbirman merged 4 commits into
mainfrom
158-subject-400
May 29, 2026
Merged

fix: allow subject/procedures 400 responses, expose error messages, fix typo#159
dbirman merged 4 commits into
mainfrom
158-subject-400

Conversation

@dbirman
Copy link
Copy Markdown
Member

@dbirman dbirman commented May 29, 2026

This PR fixes two issues that were flagged by users:

  • The subject/procedures endpoints respond with 400 for invalid responses, but the page was only accepting 200. It now accepts 200 + 400 responses but shows the 400 ones in a yellow box to highlight that they are invalid
  • When a non 200/400 response returns the page now exposes the actual error. So it shows "Not found" when for example a subject doesn't exist. Previously it just said there was an error.
  • While fixing these I noticed some small typos: the procedures section still claims we don't merge, but we do merge now, and there was a missing "to" in a sentence early on

📚 Documentation preview 📚: https://scicomp-docs--159.org.readthedocs.build/en/159/

@dbirman dbirman changed the title fix: expose full contents of error messages fix: allow subject/procedures 404 responses, expose error messages, fix typo May 29, 2026
@dbirman dbirman changed the title fix: allow subject/procedures 404 responses, expose error messages, fix typo fix: allow subject/procedures 400 responses, expose error messages, fix typo May 29, 2026
@dbirman dbirman requested a review from mekhlakapoor May 29, 2026 20:10
@dbirman dbirman merged commit 46706b1 into main May 29, 2026
1 check passed
@dbirman dbirman deleted the 158-subject-400 branch May 29, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subject endpoint responses show as 400 even though the real http endpoint is valid

2 participants