Fix/replace list#101
Open
meganrm wants to merge 91 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Mirrors the CSS custom properties in colors.css — adds missing brand colors (ALLEN_MAROON, ALLEN_ROSE, ALLEN_ORANGE, ALLEN_OCHRE, ALLEN_YELLOW) and semantic aliases (COLOR_BG_BASE, COLOR_TEXT_PRIMARY, LINK_COLOR, etc.) so components can import named tokens instead of raw hex values. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fixes "yarn: command not found" when committing via VS Code's git UI, which doesn't inherit the shell PATH. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…iles Adds --color-accent, --color-surface, --color-bg-dark, --color-feature, --color-secondary to colors.css, then updates all module CSS files to use semantic names instead of palette names (--ALLEN_BLUE, --PAGE_1, --GRAY_2, --WHITE, --BLACK, etc.). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…board into fix/replace-list
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the index page layout and IdeaRoll styling to remove reliance on the deprecated antd/List, and to make the index hero background span full viewport width while keeping inner content aligned.
Changes:
- Replace
antd/List-based IdeaRoll with a native<ul>/<li>editorial layout and corresponding CSS module updates. - Make the index page a full-width layout via
useSetLayoutConfig({ fullWidthPage: true })and restructure the hero to use an inner constrained wrapper. - Adjust theme/link hover color and add/align layout styling tokens (with a small cleanup needed to avoid duplication).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/templates/index-page.tsx | Sets fullWidthPage and wraps hero content in heroInner for consistent alignment. |
| src/components/IdeaRoll.tsx | Replaces antd/List rendering with native list markup + editorial item layout. |
| src/components/IconText.tsx | Removes now-unused component previously tied to the antd/List actions UI. |
| src/style/index-page.module.css | Updates hero/list wrappers to use shared padding tokens and new structure. |
| src/style/idea-roll.module.css | Adds new editorial list styles (tags eyebrow, title, byline, separators). |
| src/style/layout.module.css | Tweaks full-width wrapper background behavior for full-width pages. |
| src/style/colors.css | Attempts to add shared layout padding tokens (currently duplicated in file). |
| src/style/theme.ts | Updates colorLinkHover token value. |
| docs/design/specs/2026-05-20-index-page-redesign.md | Adds a design spec describing the new index page structure and IdeaRoll layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Deploy Preview for project-idea-board ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Comment on lines
55
to
+57
| colorLink: ALLEN_VIOLET, | ||
| colorLinkActive: ALLEN_GREEN, | ||
| colorLinkHover: ALLEN_GREEN, | ||
| colorLinkHover: ALLEN_VIOLET, |
Comment on lines
+69
to
+73
| <TagPopover | ||
| tag={tag} | ||
| currentSlug={item.slug} | ||
| className={eyebrowTag} | ||
| /> |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rugeli
reviewed
Jun 1, 2026
| |-------------|-------|--------|-------------------------------|-------------------------------------| | ||
| | Tag eyebrow | 10px | 700 | `var(--primary-color)` | uppercase, `letter-spacing: 0.15em` | | ||
| | Separator · | 10px | 400 | `var(--border-color)` | `margin: 0 5px` | | ||
| | Title | 19px | 800 | `var(--text-primary-color)` | `letter-spacing: -0.02em`, `line-height: 1.25` | |
There was a problem hiding this comment.
not a blocker, but looks like the title actually uses color: var(--primary-color);. maybe update one or the other for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The list component is marked as deprecated in antd docs
Also the main page looked out of style once the subpage had been updated.
Solution
Replaces the list component with a custom styled list.
Type of change
Please delete options that are not relevant.
Steps to Verify:
Screenshots (optional):