-
Notifications
You must be signed in to change notification settings - Fork 0
add cloudinary image upload support #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rugeli
wants to merge
14
commits into
main
Choose a base branch
from
gallery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b393ea8
custom widget
rugeli d1e9cfa
accept image_url
rugeli 85fda51
image url type and util
rugeli d20693b
add render image url
rugeli 1430439
generalize image url function name
rugeli 2bfc2b5
refactor: new prop ImageRenderer
rugeli c618d37
use constants for cloudinary config
rugeli ff08245
refactor: add ImgWithCaption ton images
rugeli a082cfd
maintain local images reviewable in admin page
rugeli 22f73f2
resolve gatsby image properly
rugeli d3ba66c
fall back to url if image is null
rugeli e63036a
shorter main image card
rugeli 941ea56
polling cap and null check
rugeli 6f09b16
respond to copilot's feedback: add image url support to background img
rugeli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| // Cloudinary Upload Widget configuration | ||
| // These are public, client-side values (not secrets). | ||
| // The upload preset restricts what operations are allowed. | ||
| export const CLOUDINARY_CLOUD_NAME = "dkg6lnogl"; | ||
| export const CLOUDINARY_UPLOAD_PRESET = "allen-cell"; | ||
| export const CLOUDINARY_API_KEY = "989839737788897"; | ||
|
rugeli marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Trying to believe the comment about about public facing, but it does smell strange to have something called API_KEY committed publicly! Could use .env? Maybe its fine. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love bringing the resolver pattern over into cell catalog!