-
Notifications
You must be signed in to change notification settings - Fork 14
[OGUI-1842] Add panel with run information in QCG under filters #3232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hehoon
wants to merge
18
commits into
dev
Choose a base branch
from
feature/QCG/OGUI-1842/panel-with-run-information
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
95e0352
Refactor the response object of `retrieveRunStatus` and rename it to …
hehoon da4216c
Add panel with run information in QCG under filters
hehoon 6c2587d
Rewrite updateRunInformation so that it doesn't rely on runNumber to …
hehoon e9be197
Add and use BookkeepingDto.js
hehoon c160e01
Remove unused variable
hehoon a73ae42
Use horizontal margin instead of justify center to scrolling bug
hehoon cf3ece5
Add typedef for RunInformation
hehoon c00ecc3
Rename `detectorQualities` to `detectorsQualities` and add default va…
hehoon c9b0c8b
Add a test to validate whether the run information endpoint returns t…
hehoon 2c1196a
Add `statusBadgeSuccess`, `statusBadgeFail` and `statusBadge` helper …
hehoon c8d8cd2
Display the run detector qualities in badges on a new line beneath th…
hehoon 8bd4032
Add tests for the run information and detector qualities displays
hehoon 35f42ec
Merge branch 'dev' into feature/QCG/OGUI-1840/Refactor-the-response-o…
graduta 49c4b3e
Merge branch 'feature/QCG/OGUI-1840/Refactor-the-response-object-of-r…
hehoon 1f8e58c
Merge branch 'dev' into feature/QCG/OGUI-1842/panel-with-run-information
graduta 3947c8e
Fix an issue with horizontal scrolling and the use of `justify-conten…
hehoon f0ee16c
Add components `cleanRunInformationPanel` and `detectorsQualitiesPanel`
hehoon 924bfbb
Small changes to some jsdoc
hehoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2019-2020 CERN and copyright holders of ALICE O2. | ||
| * See http://alice-o2.web.cern.ch/copyright for details of the copyright holders. | ||
| * All rights not expressly granted are reserved. | ||
| * | ||
| * This software is distributed under the terms of the GNU General Public | ||
| * License v3 (GPL Version 3), copied verbatim in the file "COPYING". | ||
| * | ||
| * In applying this license CERN does not waive the privileges and immunities | ||
| * granted to it by virtue of its status as an Intergovernmental Organization | ||
| * or submit itself to any jurisdiction. | ||
| */ | ||
|
|
||
| import { h, iconCheck, iconX } from '/js/src/index.js'; | ||
|
|
||
| /** | ||
| * A green success badge with the tick icon | ||
| * @param {string} text - Text to display in the badge | ||
| * @returns {vnode} The badge virtual node | ||
| */ | ||
| export const statusBadgeSuccess = (text) => | ||
| h('.badge.success.b-success.b1', h('.flex-row.g1', [text, iconCheck()])); | ||
|
|
||
| /** | ||
| * A red failure badge with the X icon | ||
| * @param {string} text - Text to display in the badge | ||
| * @returns {vnode} The badge virtual node | ||
| */ | ||
| export const statusBadgeFail = (text) => | ||
| h('.badge.danger.b-danger.b1', h('.flex-row.g1', [text, iconX()])); | ||
|
|
||
| /** | ||
| * A status badge with dynamic color and icon depending on success or failure. | ||
| * @param {string} text - Text to display inside the badge | ||
| * @param {boolean} success - Whether the badge represents success (`true`) or failure (`false`) | ||
| * @returns {vnode} The badge virtual node | ||
| */ | ||
| export const statusBadge = (text, success) => | ||
| success ? statusBadgeSuccess(text) : statusBadgeFail(text); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
@returnparam doc