-
Notifications
You must be signed in to change notification settings - Fork 622
[PWGHF] Add task for studies on PID variables #8617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mfaggin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot!
|
Converted to draft because of the long PR queue to avoid unnecessary compilation of unapproved code. |
Please consider the following formatting changes to AliceO2Group#8617
|
Thank you for the input @vkucera, we implemented your comments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fchinu @Marcellocosti , please see a few more suggestions.
|
Hi @vkucera, thanks for your suggestions! They have been implemented |
vkucera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fchinu for addressing my comments.
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
This PR adds a task for studying possible shortcomings in the MC description of PID variables. This can be useful both for studying whether PID variables can be safely used in ML trainings, and for possibly defining a PID systematic uncertainty for the analyses.
At the moment, only LF particles are studied (K0s, lambda and omegas for studying pi, p and K respectively), but we plan to also include HF hadrons (e.g. D*).
@Marcellocosti @Luca610 @stefanopolitano