Skip to content

Conversation

@fchinu
Copy link
Contributor

@fchinu fchinu commented Nov 22, 2024

This PR adds a task for studying possible shortcomings in the MC description of PID variables. This can be useful both for studying whether PID variables can be safely used in ML trainings, and for possibly defining a PID systematic uncertainty for the analyses.
At the moment, only LF particles are studied (K0s, lambda and omegas for studying pi, p and K respectively), but we plan to also include HF hadrons (e.g. D*).
@Marcellocosti @Luca610 @stefanopolitano

mfaggin
mfaggin previously approved these changes Nov 22, 2024
Copy link
Collaborator

@mfaggin mfaggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@mfaggin mfaggin enabled auto-merge (squash) November 22, 2024 15:47
@vkucera vkucera disabled auto-merge November 22, 2024 16:04
@vkucera vkucera marked this pull request as draft November 22, 2024 16:04
@vkucera
Copy link
Collaborator

vkucera commented Nov 22, 2024

Converted to draft because of the long PR queue to avoid unnecessary compilation of unapproved code.

Please consider the following formatting changes to AliceO2Group#8617
@Marcellocosti
Copy link
Contributor

Thank you for the input @vkucera, we implemented your comments!

@fchinu fchinu marked this pull request as ready for review November 23, 2024 09:03
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fchinu @Marcellocosti , please see a few more suggestions.

@fchinu
Copy link
Contributor Author

fchinu commented Nov 24, 2024

Hi @vkucera, thanks for your suggestions! They have been implemented

Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fchinu for addressing my comments.

@ktf ktf merged commit ba6bf39 into AliceO2Group:master Nov 25, 2024
9 checks passed
@fchinu fchinu deleted the pid_studies branch November 28, 2024 13:53
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
wefeng1110 pushed a commit to wefeng1110/O2Physics that referenced this pull request Dec 6, 2024
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
Archita-Dash pushed a commit to Archita-Dash/O2Physics that referenced this pull request Dec 11, 2024
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Dec 20, 2024
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
feisenhu pushed a commit to feisenhu/O2Physics that referenced this pull request Jan 8, 2025
Co-authored-by: marcellocosti <marcellodicostanzo00@gmail.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Marcellocosti <96481191+Marcellocosti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

6 participants