[PWGJE,Infrastructure] Create qg tree creator#15555
Draft
Physicistdana wants to merge 29 commits intoAliceO2Group:masterfrom
Draft
[PWGJE,Infrastructure] Create qg tree creator#15555Physicistdana wants to merge 29 commits intoAliceO2Group:masterfrom
Physicistdana wants to merge 29 commits intoAliceO2Group:masterfrom
Conversation
Physicistdana
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
github-actions
bot
changed the title
Physicistdana
requested review from
a team,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
Physicistdana
changed the title
Physicistdana
changed the title
Physicistdana
changed the title
Physicistdana
changed the title
vkucera
reviewed
Mar 29, 2026
PWGJE/Tasks/qgTreeCreator.cxx
Outdated
| return std::remainder(phi1 - phi2, 2.f * static_cast<float>(M_PI)); | ||
| } | ||
|
|
||
| float deltaR(float eta1, float phi1, float eta2, float phi2) |
Collaborator
There was a problem hiding this comment.
Isn't this an existing method?
Collaborator
|
Hi @Physicistdana , please:
|
vkucera
reviewed
Mar 29, 2026
Comment on lines
+30
to
+32
| constexpr int kGluon = 21; | ||
| constexpr int kQuarkMin = 1; | ||
| constexpr int kQuarkMax = 6; |
vkucera
reviewed
Mar 29, 2026
Comment on lines
+10
to
+12
| // or submit itself to any jurisdiction. | ||
| #include "PWGJE/DataModel/Jet.h" | ||
| #include "PWGJE/DataModel/JetMatching.h" |
Collaborator
There was a problem hiding this comment.
Add Doxygen documentation.
nzardosh
reviewed
Mar 30, 2026
| // find initiating parton by ancestry | ||
| //------------------------------------------------ | ||
| int getInitiatingParton(auto const& particle, | ||
| aod::McParticles const& mcParticles) |
Collaborator
There was a problem hiding this comment.
please use the derived tables such as JetParticles
| const int mpdg = mom.pdgCode(); | ||
|
|
||
| if (std::abs(mpdg) == kGluon || | ||
| (std::abs(mpdg) >= kQuarkMin && std::abs(mpdg) <= kQuarkMax)) { |
Collaborator
There was a problem hiding this comment.
what happens in the case of g->qqbar? you wrongly get a q as the mother whereas it should be a g
| void process(aod::ChargedMCDetectorLevelJets const& recoJets, | ||
| aod::ChargedMCParticleLevelJets const& truthJets, | ||
| aod::ChargedMCDetectorLevelJetsMatchedToChargedMCParticleLevelJets const& matches, | ||
| aod::McParticles const& mcParticles) |
| qg = 1; | ||
| } else if (std::abs(pdg) >= kQuarkMin && std::abs(pdg) <= kQuarkMax) { | ||
| qg = 0; | ||
| } |
Collaborator
There was a problem hiding this comment.
the indentations look wrong somehow
| int pdg = 0; | ||
|
|
||
| for (auto const& tc : | ||
| truthJet.tracks_as<aod::ChargedMCParticleLevelJetConstituent>()) { |
Collaborator
There was a problem hiding this comment.
this is not correct, as the table given here should be JetParticles. Does this even compile?
| float sumPt2 = 0; | ||
| float sumPtDr = 0; | ||
|
|
||
| for (auto const& c : jet.tracks_as<aod::ChargedMCDetectorLevelJetConstituent>()) { |
Collaborator
There was a problem hiding this comment.
here the table is wrong too, please see below
|
|
||
| void process(aod::ChargedMCDetectorLevelJets const& recoJets, | ||
| aod::ChargedMCParticleLevelJets const& truthJets, | ||
| aod::ChargedMCDetectorLevelJetsMatchedToChargedMCParticleLevelJets const& matches, |
Collaborator
There was a problem hiding this comment.
this table should be joined to ChargedMCDetectorLevelJets
| float ptResp = -1; | ||
| int qg = -1; | ||
|
|
||
| for (auto const& match : matches) { |
Collaborator
There was a problem hiding this comment.
once it is joined you can access it differently
| int qg = -1; | ||
|
|
||
| for (auto const& match : matches) { | ||
| if (match.chargedMCDetectorLevelJetId() != jet.globalIndex()) { |
| continue; | ||
| } | ||
|
|
||
| auto truthJet = truthJets.iteratorAt( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jet analysis code