[PWGEM] Add TOF nsigma pi, K, p histos to study structure in TOFnSigEle due t…#15523
Draft
feisenhu wants to merge 1 commit intoAliceO2Group:masterfrom
Draft
[PWGEM] Add TOF nsigma pi, K, p histos to study structure in TOFnSigEle due t…#15523feisenhu wants to merge 1 commit intoAliceO2Group:masterfrom
feisenhu wants to merge 1 commit intoAliceO2Group:masterfrom
Conversation
feisenhu
requested review from
alibuild,
dsekihat,
hscheid,
ivorobye,
jokonig,
mikesas and
rbailhac
as code owners
github-actions
bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional TOF PID QA histograms in the dilepton single-track QCMC workflow to help diagnose the observed structure in TOF nSigmaEle when using TOF recalculation.
Changes:
- Register new TOF n-sigma histograms for pion/kaon/proton under
Track/PID/...whencfgFillQAis enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+320
to
+322
| fRegistry.add("Track/PID/positive/hTOFNsigmaPi", "TOF n sigma pi;p_{pv} (GeV/c);n #sigma_{#pi}^{TOF}", kTH2F, {{1000, 0, 10}, {100, -5, +5}}, false); | ||
| fRegistry.add("Track/PID/positive/hTOFNsigmaKa", "TOF n sigma ka;p_{pv} (GeV/c);n #sigma_{K}^{TOF}", kTH2F, {{1000, 0, 10}, {100, -5, +5}}, false); | ||
| fRegistry.add("Track/PID/positive/hTOFNsigmaPr", "TOF n sigma pr;p_{pv} (GeV/c);n #sigma_{p}^{TOF}", kTH2F, {{1000, 0, 10}, {100, -5, +5}}, false); |
There was a problem hiding this comment.
The new TOF n-sigma histograms (Pi/Ka/Pr) are registered here, but they are never filled in the QA filling logic (fillElectronInfo currently only fills hTOFNsigmaEl for both charges). As a result these histograms will remain empty and the PR won’t achieve its stated goal. Please add the corresponding fRegistry.fill calls for positive and negative tracks in the existing cfgFillQA blocks near the hTOFNsigmaEl fills (and, if needed, guard them consistently with whatever TOF-availability condition is used elsewhere in this task).
Suggested change
| fRegistry.add("Track/PID/positive/hTOFNsigmaPi", "TOF n sigma pi;p_{pv} (GeV/c);n #sigma_{#pi}^{TOF}", kTH2F, {{1000, 0, 10}, {100, -5, +5}}, false); | |
| fRegistry.add("Track/PID/positive/hTOFNsigmaKa", "TOF n sigma ka;p_{pv} (GeV/c);n #sigma_{K}^{TOF}", kTH2F, {{1000, 0, 10}, {100, -5, +5}}, false); | |
| fRegistry.add("Track/PID/positive/hTOFNsigmaPr", "TOF n sigma pr;p_{pv} (GeV/c);n #sigma_{p}^{TOF}", kTH2F, {{1000, 0, 10}, {100, -5, +5}}, false); |
…o effect of TOF recalculation
Collaborator
|
Error while checking build/O2Physics/o2 for c0dca35 at 2026-03-25 23:49: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o effect of TOF recalculation
Adding TOF nsigma for pi, K, p, within the if case of cfgFillQA.
As I see the band within the TOF nSigmaEle when using the TOF recalculation based on the TTCA, I want to check if this is a clear structure of a different particle.