[PWGCF] Adding the option to reject half the FT0 #14925
Conversation
Adding the option to reject half of the FT0 detectors to eta dependent correlations
MartijnLaarhoven
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
github-actions
bot
changed the title
There was a problem hiding this comment.
Pull request overview
Adds configurable options to exclude specific FT0 (A/C) inner/outer ring channel ranges when building eta-dependent TPC–FT0 correlations, enabling studies that “reject half” of the FT0 acceptance.
Changes:
- Introduced new configurables to reject FT0A/FT0C inner or outer ring channels.
- Added FT0 channel-range constants for ring selection.
- Applied channel rejection during the FT0-channel loop when filling correlations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| getChannel(ft0, iCh, chanelid, ampl, corType); | ||
| if (corType == kFT0C) { | ||
| if ((cfgRejectFT0CInside && (chanelid >= kFT0CInnerRingMin && chanelid <= kFT0CInnerRingMax)) || (cfgRejectFT0COutside && (chanelid >= kFT0COuterRingMin && chanelid <= kFT0COuterRingMax))) { | ||
| continue; | ||
| } | ||
| } else if (corType == kFT0A) { | ||
| if ((cfgRejectFT0AInside && (chanelid >= kFT0AInnerRingMin && chanelid <= kFT0AInnerRingMax)) || (cfgRejectFT0AOutside && (chanelid >= kFT0AOuterRingMin && chanelid <= kFT0AOuterRingMax))) { | ||
| continue; |
There was a problem hiding this comment.
Channel rejection is applied after getChannel(), but getChannel() already fills FT0Amp/FT0AmpCorrect QA histograms with the (non-rejected) amplitude. This makes the QA plots inconsistent with the actual correlations when any cfgRejectFT0* option is enabled. Consider applying the rejection before calling getChannel(), or move the rejection logic into getChannel() (e.g., set ampl=0 / skip fills for rejected channel IDs) so QA and correlation filling are consistent.
| int chanelid = 0; | ||
| float ampl = 0.; | ||
| getChannel(ft0, iCh, chanelid, ampl, corType); | ||
| if (corType == kFT0C) { | ||
| if ((cfgRejectFT0CInside && (chanelid >= kFT0CInnerRingMin && chanelid <= kFT0CInnerRingMax)) || (cfgRejectFT0COutside && (chanelid >= kFT0COuterRingMin && chanelid <= kFT0COuterRingMax))) { |
There was a problem hiding this comment.
Local variable name chanelid appears to be a typo and reduces readability, especially now that it’s used in the new rejection logic. Consider renaming it to channelId (and updating uses in this loop) to avoid confusion.
1 participant
Adding the option to reject half of the FT0 detectors to eta dependent correlations