-
Notifications
You must be signed in to change notification settings - Fork 628
[PWGJE] Jet substructure SoftDrop #14916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| WorkflowSpec defineDataProcessing(ConfigContext const& cfgc) | ||
| { | ||
| return WorkflowSpec{adaptAnalysisTask<JetSubstructureSoftDrop>( | ||
| cfgc, TaskName{"jet-substructure-softdrop"})}; // o2-linter: disable=name/o2-task(Required for correct DPL workflow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "Required for correct DPL workflow"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had initially tried without explicitly setting the TaskName, but in that case the workflow was not starting correctly in my DPL test setup. Forcing the TaskName made the device appear and run as expected. That’s why I added the override and the linter disable. I also followed the documentation, which suggested suppressing the linter in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your task name JetSubstructureSoftDrop should generate a device name jet-substructure-soft-drop. Did you observe anything else?
| #include "fastjet/ClusterSequenceArea.hh" | ||
| #include "fastjet/PseudoJet.hh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are also external headers. Please include them using the <> format.
Add detailed jet substructure analysis for data, MCD, and MCP