Skip to content

Conversation

@fuchuncui
Copy link
Contributor

@fuchuncui fuchuncui commented Dec 17, 2025

Add batter PID check and QA,
Add run by run NUA output,
Add MCprocess for NUE correction. (by Qiuyu Xia, https://github.com/huinaibing)
Fix a bug in V0s and cascades ITS PID selection.

@github-actions github-actions bot added the pwgcf label Dec 17, 2025
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 70f464a at 2025-12-17 10:55:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14253-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:288:19: error: narrowing conversion of '((PidFlowPtCorr*)this)->PidFlowPtCorr::cfgNumberOfRuns.o2::framework::Configurable<int>::o2::framework::ConfigurablePolicyConst<int, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<int, o2::framework::kGeneric>::operator int()' from 'int' to 'double' [-Werror=narrowing]
/sw/SOURCES/O2Physics/14253-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:290:29: error: comparison of integer expressions of different signedness: 'int' and 'std::vector<int>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/14253-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:798:26: error: unused variable 'itsResponse' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/14253-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1060:43: error: comparison of integer expressions of different signedness: 'int' and 'std::vector<int>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/14253-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1036:26: error: unused variable 'itsResponse' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/14253-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1038:11: error: unused variable 'nMultTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/14253-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1103:11: error: unused variable 'nMultTPC' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 40592ce at 2025-12-17 12:51:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14253-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:288:19: error: narrowing conversion of '((PidFlowPtCorr*)this)->PidFlowPtCorr::cfgNumberOfRuns.o2::framework::Configurable<double>::o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>::operator double()' from 'double' to 'int' [-Werror=narrowing]
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
Copy link
Collaborator

vkucera commented Dec 17, 2025

@fuchuncui You are supposed to test the compilation before making the PR.

* @details default datas are from run2, note that separate pi-k and k-p needs to use difference pt range
*/
// separate pi and k
O2_DEFINE_CONFIGURABLE(cfgPtMin4ITS_pi_k, float, 0.2, "pt min for ITS to separate pi and k");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow naming conventions

* If the track pt is out of a detector's valid range, that detector's check is skipped.
*/
template <typename TrackObject>
bool isPion(TrackObject track)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't take by value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuchuncui, @vkucera is right
If the track is passed by value, as it is now, a full copy of the complete track is passed to the function which is a waste of resources.
It has to be passed by reference, isPion(TrackObject const &track), so that only the reference to the track is then passed to the function

@victor-gonzalez victor-gonzalez enabled auto-merge (squash) December 18, 2025 12:54
@victor-gonzalez victor-gonzalez merged commit f7bab94 into AliceO2Group:master Dec 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants