Skip to content

Conversation

@FDUEnrich
Copy link
Contributor

No description provided.

FDUEnrich and others added 24 commits October 12, 2025 15:07
[PWGHF] Please consider the following formatting changes to AliceO2Group#13353
Added new mass columns for Omega and Xi particles and updated event selection criteria.
Please consider the following formatting changes to AliceO2Group#14252
@FDUEnrich FDUEnrich marked this pull request as ready for review December 18, 2025 07:44
Please consider the following formatting changes to AliceO2Group#14252
@vkucera vkucera marked this pull request as draft December 18, 2025 14:20
@vkucera
Copy link
Collaborator

vkucera commented Dec 18, 2025

Stop wasting compilation resources! Your PR doesn't pass required tests and you haven't addressed my comments, so why did you open the PR for review?

setLabelHistoCands(hCandidatesCascPiOrK);

// init HF event selection helper (centrality, event cuts, monitoring)
hfEvSel.init(registry, nullptr);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nullptr is useless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Vit. This is recommended by Fabrizio.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@FDUEnrich FDUEnrich marked this pull request as ready for review December 24, 2025 10:23
Comment on lines 412 to 419
enum ChannelType {
ANY = 0,
XIC_TO_XI_PI = 1,
XIC_TO_OMEGA_KA = 2,
OMEGAC_TO_OMEGA_PI = 3,
OMEGAC_TO_OMEGA_KA = 4,
OMEGAC_TO_XI_PI = 5
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow naming conventions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, please tell me directly, where is the problem with the name?

@vkucera vkucera marked this pull request as draft December 24, 2025 16:19
@FDUEnrich FDUEnrich marked this pull request as ready for review December 26, 2025 06:32
@vkucera vkucera marked this pull request as draft December 26, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants