Skip to content

Conversation

@ynishida-style
Copy link
Contributor

To address the memory consumption issue, I improved the loop ordering and related aspects.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title fix code to avoid memory consumption error [PWGJE] fix code to avoid memory consumption error Dec 16, 2025
@ynishida-style ynishida-style changed the title [PWGJE] fix code to avoid memory consumption error [PWGJE] fix code to avoid memory consumption problem Dec 16, 2025
@vkucera
Copy link
Collaborator

vkucera commented Dec 16, 2025

@ynishida-style Please make the scope of your changes clear from your PR title. The current title doesn't tell me which file or analysis is concerned.

@ynishida-style ynishida-style changed the title [PWGJE] fix code to avoid memory consumption problem [PWGJE] improved the loop ordering to avoid memory consumption problem in processes using jet Dec 17, 2025
@ynishida-style ynishida-style changed the title [PWGJE] improved the loop ordering to avoid memory consumption problem in processes using jet [PWGJE] improved the loop ordering in processes using jet Dec 17, 2025
@ynishida-style
Copy link
Contributor Author

ynishida-style commented Dec 17, 2025

@ynishida-style Please make the scope of your changes clear from your PR title. The current title doesn't tell me which file or analysis is concerned.

Thank you for the comment.

In this change, I modified the loop structure by moving the jet loop inside the track loop (instead of looping over tracks inside the jet loop).

This modification was applied to all processes that use jets. 

And I changed this PR title to a clearer name.

@vkucera
Copy link
Collaborator

vkucera commented Dec 17, 2025

@ynishida-style Thanks for the update but the title still does not mention any file nor any analysis.

@ynishida-style ynishida-style changed the title [PWGJE] improved the loop ordering in processes using jet [PWGJE] Optimize loop ordering and cache jets in JetShapeTask Dec 17, 2025
@ynishida-style
Copy link
Contributor Author

@ynishida-style Thanks for the update but the title still does not mention any file nor any analysis.

Thank you for the comment. I have updated the title to explicitly mention the task name. Could you please check this?

@vkucera
Copy link
Collaborator

vkucera commented Dec 17, 2025

@ynishida-style Thanks for the update but the title still does not mention any file nor any analysis.

Thank you for the comment. I have updated the title to explicitly mention the task name. Could you please check this?

Thanks @ynishida-style , that's a good title.

@nzardosh nzardosh merged commit 02318e1 into AliceO2Group:master Dec 17, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants