-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGJE] Optimize loop ordering and cache jets in JetShapeTask #14231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 0 errors, |
|
@ynishida-style Please make the scope of your changes clear from your PR title. The current title doesn't tell me which file or analysis is concerned. |
Thank you for the comment. In this change, I modified the loop structure by moving the jet loop inside the track loop (instead of looping over tracks inside the jet loop). This modification was applied to all processes that use jets. And I changed this PR title to a clearer name. |
a7c7388 to
cdf3d56
Compare
|
@ynishida-style Thanks for the update but the title still does not mention any file nor any analysis. |
Thank you for the comment. I have updated the title to explicitly mention the task name. Could you please check this? |
Thanks @ynishida-style , that's a good title. |
To address the memory consumption issue, I improved the loop ordering and related aspects.