Skip to content

[PWGJE] fix large memory consumption #14226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ynishida-style wants to merge 2 commits into from
Closed

[PWGJE] fix large memory consumption #14226

ynishida-style wants to merge 2 commits into from

Conversation

@ynishida-style
Copy link
Contributor

@ynishida-style ynishida-style commented Dec 15, 2025

I improved the loop ordering to address the memory consumption issue.

@github-actions github-actions bot added the pwgje label Dec 15, 2025
@github-actions github-actions bot changed the title fix large memory consumption [PWGJE] fix large memory consumption Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild
Copy link
Collaborator

alibuild commented Dec 15, 2025

Error while checking build/O2Physics/o2 for 8cdf283 at 2025-12-15 20:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14226-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:297:27: error: assignment of read-only location 'jet.JetShapeTask::processJetShape(const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<2589500881>, o2::aod::Hash<2537443056>, o2::aod::Hash<2286545062> > > >::iterator&, const o2::aod::JetTracks&, o2::soa::Join<o2::soa::Table<o2::aod::Hash<16816485>, o2::aod::Hash<3656892203>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<827227225>, o2::aod::Hash<3559517444>, o2::aod::Hash<2286545062> > >&)::JetAccumulator::sumSig.std::vector<float>::operator[](i)'
/sw/SOURCES/O2Physics/14226-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:310:27: error: assignment of read-only location 'jet.JetShapeTask::processJetShape(const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<2589500881>, o2::aod::Hash<2537443056>, o2::aod::Hash<2286545062> > > >::iterator&, const o2::aod::JetTracks&, o2::soa::Join<o2::soa::Table<o2::aod::Hash<16816485>, o2::aod::Hash<3656892203>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<827227225>, o2::aod::Hash<3559517444>, o2::aod::Hash<2286545062> > >&)::JetAccumulator::sumBg1.std::vector<float>::operator[](i)'
/sw/SOURCES/O2Physics/14226-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:322:27: error: assignment of read-only location 'jet.JetShapeTask::processJetShape(const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<2589500881>, o2::aod::Hash<2537443056>, o2::aod::Hash<2286545062> > > >::iterator&, const o2::aod::JetTracks&, o2::soa::Join<o2::soa::Table<o2::aod::Hash<16816485>, o2::aod::Hash<3656892203>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<827227225>, o2::aod::Hash<3559517444>, o2::aod::Hash<2286545062> > >&)::JetAccumulator::sumBg2.std::vector<float>::operator[](i)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Dec 15, 2025

Error while checking build/O2Physics/o2 for eab758d at 2025-12-15 20:22:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14226-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:296:27: error: assignment of read-only location 'jet.JetShapeTask::processJetShape(const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<2589500881>, o2::aod::Hash<2537443056>, o2::aod::Hash<2286545062> > > >::iterator&, const o2::aod::JetTracks&, o2::soa::Join<o2::soa::Table<o2::aod::Hash<16816485>, o2::aod::Hash<3656892203>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<827227225>, o2::aod::Hash<3559517444>, o2::aod::Hash<2286545062> > >&)::JetAccumulator::sumSig.std::vector<float>::operator[](i)'
/sw/SOURCES/O2Physics/14226-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:309:27: error: assignment of read-only location 'jet.JetShapeTask::processJetShape(const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<2589500881>, o2::aod::Hash<2537443056>, o2::aod::Hash<2286545062> > > >::iterator&, const o2::aod::JetTracks&, o2::soa::Join<o2::soa::Table<o2::aod::Hash<16816485>, o2::aod::Hash<3656892203>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<827227225>, o2::aod::Hash<3559517444>, o2::aod::Hash<2286545062> > >&)::JetAccumulator::sumBg1.std::vector<float>::operator[](i)'
/sw/SOURCES/O2Physics/14226-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:321:27: error: assignment of read-only location 'jet.JetShapeTask::processJetShape(const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<2589500881>, o2::aod::Hash<2537443056>, o2::aod::Hash<2286545062> > > >::iterator&, const o2::aod::JetTracks&, o2::soa::Join<o2::soa::Table<o2::aod::Hash<16816485>, o2::aod::Hash<3656892203>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<827227225>, o2::aod::Hash<3559517444>, o2::aod::Hash<2286545062> > >&)::JetAccumulator::sumBg2.std::vector<float>::operator[](i)'
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@nzardosh nzardosh Awaiting requested review from nzardosh nzardosh is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

Assignees

No one assigned

Labels

pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ynishida-style @alibuild