Skip to content

[PWGDQ] In filterPbPb, save new bc regardless of SGSelector desicion #14154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iarsene merged 1 commit into from
Dec 10, 2025
Merged

[PWGDQ] In filterPbPb, save new bc regardless of SGSelector desicion #14154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions PWGDQ/Tasks/filterPbPb.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGDQ/Tasks/filterPbPb.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

Check failure on line 1 in PWGDQ/Tasks/filterPbPb.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Use constant references for table subscriptions in process functions.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -39,9 +39,9 @@
Produces<aod::DQRapidityGapFilter> eventRapidityGapFilter;
OutputObj<TH1D> fFilterOutcome{"Filter outcome"};

Configurable<int> fConfigNDtColl{"cfgNDtColl", 4, "Number of standard deviations to consider in BC range"};

Check failure on line 42 in PWGDQ/Tasks/filterPbPb.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<int> fConfigMinNBCs{"cfgMinNBCs", 7, "Minimum number of BCs to consider in BC range"};

Check failure on line 43 in PWGDQ/Tasks/filterPbPb.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<int> fConfigMinNPVCs{"cfgMinNPVCs", 2, "Minimum number of PV contributors"};

Check failure on line 44 in PWGDQ/Tasks/filterPbPb.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<int> fConfigMaxNPVCs{"cfgMaxNPVCs", 5, "Maximum number of PV contributors"};
Configurable<float> fConfigMaxFITTime{"cfgMaxFITTime", 4, "Maximum time in FIT"};
Configurable<float> fConfigFV0AmpLimit{"cfgFV0AmpLimit", 0, "FV0 amplitude limit for event selection"};
Expand Down Expand Up @@ -84,7 +84,7 @@
}

void processUDSGSelector(MyEvents::iterator const& collision, MyBCs const& bcs,
aod::FT0s& ft0s, aod::FV0As& fv0as, aod::FDDs& fdds, aod::Zdcs& /*zdcs*/)

Check failure on line 87 in PWGDQ/Tasks/filterPbPb.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::Zdcs& /*zdcs*/ is not const&.

Check failure on line 87 in PWGDQ/Tasks/filterPbPb.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::FDDs& fdds is not const&.

Check failure on line 87 in PWGDQ/Tasks/filterPbPb.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::FV0As& fv0as is not const&.

Check failure on line 87 in PWGDQ/Tasks/filterPbPb.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::FT0s& ft0s is not const&.
{
uint64_t filter = 0;
fFilterOutcome->Fill(1, 1.);
Expand All @@ -99,23 +99,23 @@
auto isSGEvent = sgSelector.IsSelected(sgCuts, collision, bcRange, bc);
int issgevent = isSGEvent.value;
// Translate SGSelector values to DQEventFilter values
if (issgevent == 0) {
if (issgevent == sgselector::SingleGapA) {
filter |= (static_cast<uint64_t>(1) << VarManager::kSingleGapA);
fFilterOutcome->Fill(3, 1);
} else if (issgevent == 1) {
} else if (issgevent == sgselector::SingleGapC) {
filter |= (static_cast<uint64_t>(1) << VarManager::kSingleGapC);
fFilterOutcome->Fill(4, 1);
} else if (issgevent == 2) {
} else if (issgevent == sgselector::DoubleGap) {
filter |= (static_cast<uint64_t>(1) << VarManager::kDoubleGap);
fFilterOutcome->Fill(2, 1);
} else if (issgevent == 3) {
} else if (issgevent == sgselector::NoUpc) {
fFilterOutcome->Fill(5, 1);
} else if (issgevent == 4) {
} else if (issgevent == sgselector::TrkOutOfRange) {
fFilterOutcome->Fill(6, 1);
}

// Get closest bc with FIT activity above threshold
if (isSGEvent.bc && issgevent < 2) {
if (isSGEvent.bc) {
newbc = *(isSGEvent.bc);
}
upchelpers::FITInfo fitInfo{};
Expand All @@ -130,7 +130,7 @@
eventRapidityGapFilter(filter, newbc.globalIndex());
}

void processDummy(MyEvents&)

Check failure on line 133 in PWGDQ/Tasks/filterPbPb.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument MyEvents& is not const&.
{
// do nothing
}
Expand Down
Loading