[PWGUD] Fix some bug tracker issues #14085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sigurdnese
commented
Dec 4, 2025
sigurdnese
commented
- Fix dangling pointer to newbc in SGSelector.IsSelected by using std::shared_ptr
- Some minor fixes to clang-tidy and cpplint issues
sigurdnese
requested review from
alibuild,
amatyja and
rolavick
as code owners
|
O2 linter results: ❌ 26 errors, |
github-actions
bot
changed the title
rolavick
approved these changes
Dec 4, 2025
Collaborator
|
Thanks a lot @sigurdnese ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.