[PWGCF] Addition of MC truth process #14074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 0 errors, |
Preet-Bhanjan
added a commit
to Preet-Bhanjan/O2Physics
that referenced
this pull request
Dec 3, 2025
Please consider the following formatting changes to AliceO2Group#14074
Preet-Bhanjan
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
Please consider the following formatting changes to AliceO2Group#14074
Comment on lines
+1518
to
+1540
| if (std::abs(track.mcParticle().pdgCode()) == PDG_t::kPiPlus) { | ||
| histos.fill(HIST("hNsigmaPionTrue"), track.pt()); | ||
|
|
||
| if (pidIndex == kPions) { | ||
| histos.fill(HIST("hNsigmaPionTruePositives"), track.pt()); | ||
| } | ||
| } // Pion condition | ||
|
|
||
| if (std::abs(track.mcParticle().pdgCode()) == PDG_t::kKPlus) { | ||
| histos.fill(HIST("hNsigmaKaonTrue"), track.pt()); | ||
|
|
||
| if (pidIndex == kKaons) { | ||
| histos.fill(HIST("hNsigmaKaonTruePositives"), track.pt()); | ||
| } | ||
| } // Kaon condition | ||
|
|
||
| if (std::abs(track.mcParticle().pdgCode()) == PDG_t::kProton) { | ||
| histos.fill(HIST("hNsigmaProtonTrue"), track.pt()); | ||
|
|
||
| if (pidIndex == kProtons) { | ||
| histos.fill(HIST("hNsigmaProtonTruePositives"), track.pt()); | ||
| } | ||
| } // Proton condition |
Collaborator
There was a problem hiding this comment.
I guess that, except this part, the rest is the same as for data
If you template the whole processing and condition, constexpr, this part to the existence of the McParticleId column on the received tracks table you will be able to have a single function, without replicating code, for both data and reconstructed MC
victor-gonzalez
approved these changes
Dec 3, 2025
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, have a look at my comment in case you want to consider it for future iterations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.