[PWGHF] correct daughter-track removal from TPC Q-vector in SP method #14071
Conversation
github-actions
bot
changed the title
|
O2 linter results: ❌ 0 errors, |
zhangbiao-phy
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
stefanopolitano and
vkucera
as code owners
| if (storeEP) { | ||
| values[n++] = cosNPhi; | ||
| values[n++] = sinNPhi; | ||
| values[n++] = cosDeltaPhi; | ||
| } | ||
| if (storeMl) { | ||
| values[n++] = outputMl[0]; | ||
| values[n++] = outputMl[1]; | ||
| } | ||
| if (storeCandEta) { | ||
| values[n++] = eta; | ||
| } |
There was a problem hiding this comment.
This is very bug-prone. The positions of elements depend on external switches.
There was a problem hiding this comment.
Thanks for the comment, I see your point. In this implementation the element positions are controlled by the same switches and in the same order as in the axis definition
There was a problem hiding this comment.
Yes, but you have to manually check the correct order.
There was a problem hiding this comment.
indeed, but this is current solution! Maybe I will find more smart way in the next PR
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @zhangbiao-phy.
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @zhangbiao-phy.
3 participants
I found the D0 v2 is enhanced a lot when I use the TPC or TPCpos and TPCneg as reference Q vector, the issue is normalization of the Q-vector, I try to fix it by the method show in the first bullet:
Subtract only the prongs that contribute to the selected sub-event:
TPCPos: η > 0
TPCNeg: η < 0
TPCTot: all prongs
Unified the daughter-track calculation into a single helper (
getQvecDtracks).FillThnto make it more flexible and robustTagging the flow analyser for comments and questions: @stefanopolitano @wuctlby @Marcellocosti