Skip to content

Conversation

@rashigupt
Copy link
Contributor

@rashigupt rashigupt commented Dec 1, 2025

Added two new columns in electronSelectionWithTPCEmcal.cxx:

MassLike for like-sign electron pairs

MassUnlike for unlike-sign electron pairs

Implemented the TPC–TOF selection conditions inside electronSelectionWithTPCEmcal.cxx to ensure electron PID cuts are applied consistently at the selection stage.

Removed the TPC–TOF condition from correlatorHFeHadron.cxx since it is now handled entirely in the electron selection step.

Two separate columns are included in the analysis table: one corresponding to the LSmass selection and the other to the ULmass selection, and the common mass column has been removed.
We define the mass column in the analysis by splitting it into two separate columns, LSmass and ULmass.
…ass.

We use the mass column correctly by separating it into LSmass and ULmass.
@github-actions github-actions bot changed the title We use the mass column correctly by separating it into LSmass and ULmass. [PWGHF] We use the mass column correctly by separating it into LSmass and ULmass. Dec 1, 2025
@rashigupt rashigupt changed the title [PWGHF] We use the mass column correctly by separating it into LSmass and ULmass. We use the mass column correctly by separating it into LSmass and ULmass in electronselectionwithTPCEmcal and CorrelatorHfeHadron.cxx Dec 1, 2025
@github-actions github-actions bot changed the title We use the mass column correctly by separating it into LSmass and ULmass in electronselectionwithTPCEmcal and CorrelatorHfeHadron.cxx [PWGHF] We use the mass column correctly by separating it into LSmass and ULmass in electronselectionwithTPCEmcal and CorrelatorHfeHadron.cxx Dec 1, 2025
@rashigupt rashigupt changed the title [PWGHF] We use the mass column correctly by separating it into LSmass and ULmass in electronselectionwithTPCEmcal and CorrelatorHfeHadron.cxx We use the mass column correctly in electronselectionwithTPCEmcal and CorrelatorHfeHadron.cxx Dec 1, 2025
@github-actions github-actions bot changed the title We use the mass column correctly in electronselectionwithTPCEmcal and CorrelatorHfeHadron.cxx [PWGHF] We use the mass column correctly in electronselectionwithTPCEmcal and CorrelatorHfeHadron.cxx Dec 1, 2025
@vkucera vkucera marked this pull request as draft December 1, 2025 11:21
@vkucera
Copy link
Collaborator

vkucera commented Dec 1, 2025

@rashigupt Don't open your PR as ready for review if it fails the tests.
The PR title is very ambiguous. As it is, it's just a statement that something is OK. That's not a reason to modify the code. You should state what changes are made by the PR.

@rashigupt rashigupt changed the title [PWGHF] We use the mass column correctly in electronselectionwithTPCEmcal and CorrelatorHfeHadron.cxx [PWGHF] Add MassLike and unlikesign column in tbale Dec 2, 2025
@rashigupt rashigupt changed the title [PWGHF] Add MassLike and unlikesign column in tbale [PWGHF] Add MassLike and unlikesign column in table Dec 2, 2025
@rashigupt
Copy link
Contributor Author

rashigupt commented Dec 3, 2025

Dear expert, please tell me why it does not build?

@vkucera
Copy link
Collaborator

vkucera commented Dec 3, 2025

Dear expert, please tell me why it does not build?

Dear @rashigupt , please read the contribution guidelines. It is all explained there.

@rashigupt rashigupt marked this pull request as ready for review December 3, 2025 12:47
@rashigupt
Copy link
Contributor Author

rashigupt commented Dec 3, 2025

I was able to build the code successfully on my local machine, but it failed in the build system. Could you kindly help me understand the reason for this failure?

@alibuild
Copy link
Collaborator

alibuild commented Dec 3, 2025

Error while checking build/O2Physics/o2 for 8cf1be2 at 2025-12-03 15:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:35:38: error: 'DDbarPair' is not a member of 'o2::aod'
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:35:54: error: 'DDbarRecoInfo' is not a member of 'o2::aod'
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:35:67: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:35:67: error: template argument 2 is invalid
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:35:28: error: '<expression error>' in namespace 'o2::soa' does not name a type
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:43:10: error: 'RecoDecay' has not been declared
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:51:10: error: 'RecoDecay' has not been declared
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:228:20: error: 'o2::aod::DDbarPairFull' has not been declared
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:285:21: error: 'o2::aod::DDbarPairFull' has not been declared
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:230:34: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:230:34: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:287:34: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/14045-slc9_x86-64/0/ALICE3/Tasks/alice3-taskcorrelationDDbar.cxx:287:34: error: 'end' was not declared in this scope
/sw/slc9_x86-64/O2/daily-20251203-0000-local1/include/Framework/AnalysisTask.h:156:49: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::inputsFromArgs(void (alice3taskcorrelationddbar::*&)(const int&), const char*, bool&, std::vector<o2::framework::InputSpec>&, std::vector<ExpressionInfo>&)'
/sw/slc9_x86-64/O2/daily-20251203-0000-local1/include/Framework/AnalysisTask.h:167:48: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::cacheFromArgs(void (alice3taskcorrelationddbar::*&)(const int&), bool&, o2::framework::Cache&, o2::framework::Cache&)'
/sw/slc9_x86-64/O2/daily-20251203-0000-local1/include/Framework/AnalysisTask.h:290:46: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::extract<std::decay_t<const int&>, 0>(o2::framework::InputRecord&, std::vector<ExpressionInfo>&, const unsigned int&)'
/sw/slc9_x86-64/O2/daily-20251203-0000-local1/include/Framework/AnalysisTask.h:335:40: error: static assertion failed: Single argument of process() should be a table-like or an iterator
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft December 3, 2025 14:49
@vkucera
Copy link
Collaborator

vkucera commented Dec 3, 2025

Dear @rashigupt ,

  • I had explicitly asked you to not mark your PR as ready for review if it fails the tests! You did it again!
  • More importantly, your PR completely replaces the content of PWGHF/HFC/DataModel/CorrelationTables.h with the content of PWGHF/HFL/DataModel/ElectronSelectionTable.h! This is why the builds failed. Your PR cannot compile on any machine so I don't believe your claim that you were able to build the code successfully on your local machine.
  • Test your changes properly before you make a PR and stop wasting time and resources of your colleagues!
  • Btw, the PR title is still too vague.

@rashigupt
Copy link
Contributor Author

Dear Vit,

I sincerely apologize for the mistake.
Due to an error on my side, the wrong file got replaced and that caused the build failure. I understand that this created unnecessary work for you and the team.

I will fix the file immediately, ensure the code compiles locally, and run the full set of tests before marking the PR as ready for review again.

Thank you for pointing it out, and sorry again for the inconvenience.

@rashigupt rashigupt changed the title [PWGHF] Add MassLike and unlikesign column in table [PWGHF] Implementation of MassLike/MassUnlike Columns Move TPC–TOF PID Cuts to electronSelectionWithTPCEmcal.cxx Dec 3, 2025
@rashigupt rashigupt changed the title [PWGHF] Implementation of MassLike/MassUnlike Columns Move TPC–TOF PID Cuts to electronSelectionWithTPCEmcal.cxx [PWGHF] Implementation of MassLike/MassUnlike Columns and Move TPC–TOF PID Cuts to electronSelectionWithTPCEmcal.cxx Dec 3, 2025
@rashigupt rashigupt closed this Dec 4, 2025
@rashigupt rashigupt deleted the rashi branch December 4, 2025 04:43
@rashigupt rashigupt restored the rashi branch December 4, 2025 04:43
@rashigupt rashigupt deleted the rashi branch December 4, 2025 04:43
@rashigupt rashigupt restored the rashi branch December 4, 2025 04:47
@rashigupt rashigupt reopened this Dec 4, 2025
@rashigupt rashigupt marked this pull request as ready for review December 4, 2025 05:22
@vkucera
Copy link
Collaborator

vkucera commented Dec 4, 2025

Thanks @rashigupt for the fixes.

@rashigupt
Copy link
Contributor Author

Dear expert, please approve and merge the code.

@rashigupt
Copy link
Contributor Author

Dear expert, if you have no further comments, kindly approve and merge the code.

@jpxrk jpxrk merged commit c6a8a6d into AliceO2Group:master Dec 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants