-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGHF] Implementation of MassLike/MassUnlike Columns and Move TPC–TOF PID Cuts to electronSelectionWithTPCEmcal.cxx #14045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Two separate columns are included in the analysis table: one corresponding to the LSmass selection and the other to the ULmass selection, and the common mass column has been removed.
We define the mass column in the analysis by splitting it into two separate columns, LSmass and ULmass.
…ass. We use the mass column correctly by separating it into LSmass and ULmass.
|
@rashigupt Don't open your PR as ready for review if it fails the tests. |
|
Dear expert, please tell me why it does not build? |
Dear @rashigupt , please read the contribution guidelines. It is all explained there. |
|
I was able to build the code successfully on my local machine, but it failed in the build system. Could you kindly help me understand the reason for this failure? |
|
Error while checking build/O2Physics/o2 for 8cf1be2 at 2025-12-03 15:15: Full log here. |
|
Dear @rashigupt ,
|
|
Dear Vit, I sincerely apologize for the mistake. I will fix the file immediately, ensure the code compiles locally, and run the full set of tests before marking the PR as ready for review again. Thank you for pointing it out, and sorry again for the inconvenience. |
|
Thanks @rashigupt for the fixes. |
|
Dear expert, please approve and merge the code. |
|
Dear expert, if you have no further comments, kindly approve and merge the code. |
Added two new columns in electronSelectionWithTPCEmcal.cxx:
MassLike for like-sign electron pairs
MassUnlike for unlike-sign electron pairs
Implemented the TPC–TOF selection conditions inside electronSelectionWithTPCEmcal.cxx to ensure electron PID cuts are applied consistently at the selection stage.
Removed the TPC–TOF condition from correlatorHFeHadron.cxx since it is now handled entirely in the electron selection step.