Skip to content

[PWGCF] Optimize nsigma shift and MC closure test in EbyE task partNumFluc #14031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shouqiye merged 1 commit into from
Nov 29, 2025
Merged

[PWGCF] Optimize nsigma shift and MC closure test in EbyE task partNumFluc #14031

shouqiye merged 1 commit into from
Nov 29, 2025

Conversation

@fsii
Copy link
Contributor

@fsii fsii commented Nov 29, 2025

  1. Add a configurable of CCDB URL
  2. Optimize nsigma shift reading
  3. Optimize efficiency getter
  4. Optimize MC closure test

@github-actions github-actions bot added the pwgcf label Nov 29, 2025
@github-actions
Copy link

github-actions bot commented Nov 29, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@fsii fsii marked this pull request as ready for review November 29, 2025 01:52
@alibuild
Copy link
Collaborator

alibuild commented Nov 29, 2025

Error while checking build/O2Physics/o2 for 40164d7 at 2025-11-29 03:38:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/14031-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/partNumFluc.cxx:1204:18: error: inconsistent types 'const TH3*' and 'std::nullptr_t' deduced for lambda return type
ninja: build stopped: subcommand failed.

Full log here.

@fsii fsii marked this pull request as draft November 29, 2025 02:39
@fsii fsii marked this pull request as ready for review November 29, 2025 04:34
@shouqiye shouqiye merged commit 4666ef1 into AliceO2Group:master Nov 29, 2025
13 checks passed
@fsii fsii deleted the myfeature branch November 29, 2025 16:40
yakparo pushed a commit to yakparo/O2Physics that referenced this pull request Nov 29, 2025
@fsii @yakparo
[PWGCF] Optimize nsigma shift and MC closure test in EbyE task partNu…
af9640e 
…mFluc (AliceO2Group#14031)
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@fsii
[PWGCF] Optimize nsigma shift and MC closure test in EbyE task partNu…
f9f5336 
…mFluc (AliceO2Group#14031)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shouqiye shouqiye shouqiye approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fsii @alibuild @shouqiye