[PWGHF] Refactory of charm reso derived data creator to improve compilation time #14027

fgrosa · 2025-11-28T16:28:05Z

@Luca610 @vkucera this PR implements the refactory discussed to improve the compilation time of O2Physics. In particular, I splitted the derived data creator in 3, one for each D meson species, by keeping the possibility to have combinations with V0, or tracks, or both in all the three new derived data creators.

Before merging I would still like to test it and compare the outputs with the current version to be sure that I did not introduce any bug.

Pinging for info other users @zhangbiao-phy @cterrevo

github-actions · 2025-11-28T16:28:20Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 3 disabled

Please consider the following formatting changes to AliceO2Group#14027

vkucera · 2025-11-28T16:50:21Z

Thanks a lot @fgrosa !
Please make sure that there are no errors or warnings left before marking it ready for review.
There seem to be many duplicated sections that would be worth factoring out.

PWGHF/D2H/Core/DataCreationCharmReso.h

…to reso

Please consider the following formatting changes to AliceO2Group#14027

fgrosa · 2025-12-01T18:07:45Z

Thanks a lot @fgrosa ! Please make sure that there are no errors or warnings left before marking it ready for review. There seem to be many duplicated sections that would be worth factoring out.

Hi @vkucera, thanks for the feedback! I still factored out histograms and most of the configurables, and I simplified a bit the event selection. I would consider it as satisfactory for this version (further improvements can of course be implemented in the future), to merge it in a ~short timescale. However, before marking as ready for review however I still want to test it to make sure that it does not introduces bugs to the analysis.

PWGHF/D2H/Core/DataCreationCharmReso.h

vkucera · 2025-12-01T19:52:21Z

PWGHF/D2H/Core/DataCreationCharmReso.h

+  o2::framework::Configurable<float> maxEta{"maxEta", 0.8, "maximum pseudorapidity for single tracks to be paired with D mesons"};
+  o2::framework::Configurable<float> minPt{"minPt", 0.1, "minimum pT for single tracks to be paired with D mesons"};
+  o2::framework::Configurable<float> maxNsigmaTpcPi{"maxNsigmaTpcPi", -1., "maximum pion NSigma in TPC for single tracks to be paired with D mesons; set negative to reject"};
+  o2::framework::Configurable<float> maxNsigmaTpcKa{"maxNsigmaTpcKa", -1., "maximum kaon NSigma in TPC for single tracks to be paired with D mesons; set negative to reject"};
+  o2::framework::Configurable<float> maxNsigmaTpcPr{"maxNsigmaTpcPr", 3., "maximum proton NSigma in TPC for single tracks to be paired with D mesons; set negative to reject"};


Min, Max are attributes, not quantities, so should be appended at the end.

vkucera · 2025-12-01T19:53:13Z

PWGHF/D2H/Core/DataCreationCharmReso.h

+  o2::framework::Configurable<float> cutMassDMin{"cutMassDMin", 1.83, "minimum mass for D0 and Dplus candidates"};   // o2-linter: disable=pdg/explicit-mass (false positive)
+  o2::framework::Configurable<float> cutMassDMax{"cutMassDMax", 1.92, "maximum mass for D0 and Dplus candidates"};   // o2-linter: disable=pdg/explicit-mass (false positive)
+  o2::framework::Configurable<float> cutMassDstarMin{"cutMassDstarMin", 0.139, "minimum mass for Dstar candidates"}; // o2-linter: disable=pdg/explicit-mass (false positive)
+  o2::framework::Configurable<float> cutMassDstarMax{"cutMassDstarMax", 0.175, "maximum mass for Dstar candidates"}; // o2-linter: disable=pdg/explicit-mass (false positive)
+  o2::framework::Configurable<float> cutMassK0sMin{"cutMassK0sMin", 0.485, "minimum mass for K0s candidates"};       // o2-linter: disable=pdg/explicit-mass (false positive)
+  o2::framework::Configurable<float> cutMassK0sMax{"cutMassK0sMax", 0.509, "maximum mass for K0s candidates"};       // o2-linter: disable=pdg/explicit-mass (false positive)


The prefix cut is redundant.

PWGHF/D2H/Core/DataCreationCharmReso.h

fgrosa · 2025-12-02T13:06:49Z

I tested the code for two cases (D*+V0 and D+V0) and it gives exactly the same output as the previous version (see small example below for one distribution, they are all the same between old and new version).

@vkucera I also implemented your latest suggestions, except for the renaming of configurables. Since they are used in several hyperloop wagons I prefer not to modify them at this stage, also because there are several cases to be tested (I would ask @Luca610 to help me by checking from the hyperloop wagons he has already defined that he gets what is expected in all cases), and changing the name of configurables introduces an unnecessary complication.

vkucera · 2025-12-02T13:19:21Z

Thanks a lot @fgrosa for addressing the comments. Fine for the configurables. However, there are remaining issues reported by the linter which would be better to fix before merging.

fgrosa · 2025-12-02T13:37:45Z

Thanks a lot @fgrosa for addressing the comments. Fine for the configurables. However, there are remaining issues reported by the linter which would be better to fix before merging.

Also warnings addressed!

vkucera · 2025-12-02T13:51:18Z

Thanks a lot @fgrosa for addressing the comments. Fine for the configurables. However, there are remaining issues reported by the linter which would be better to fix before merging.

Also warnings addressed!

Perfect! Thanks!

alibuild · 2025-12-02T15:44:04Z

Error while checking build/O2Physics/o2 for 27b13d0 at 2025-12-02 16:44:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/14027-slc9_x86-64/0/PWGHF/D2H/TableProducer/dataCreatorJpsiHadReduced.cxx:267:19: error: redeclaration of 'constexpr const int NumBinsEvents'
ninja: build stopped: subcommand failed.

Full log here.

alibuild

Auto-approving on behalf of @fgrosa.

Refactory of charm reso derived data creator to improve compilation time

8d5bb9b

github-actions bot added the pwghf PWG-HF label Nov 28, 2025

github-actions bot changed the title ~~Refactory of charm reso derived data creator to improve compilation time~~ [PWGHF] Refactory of charm reso derived data creator to improve compilation time Nov 28, 2025

Please consider the following formatting changes

6d96442

alibuild mentioned this pull request Nov 28, 2025

Please consider the following formatting changes to #14027 fgrosa/O2Physics#134

Merged

Merge pull request #134 from alibuild/alibot-cleanup-14027

b9fbf6a

Please consider the following formatting changes to AliceO2Group#14027

vkucera reviewed Nov 28, 2025

View reviewed changes

PWGHF/D2H/Core/DataCreationCharmReso.h Outdated Show resolved Hide resolved

vkucera reviewed Nov 28, 2025

View reviewed changes

PWGHF/D2H/Core/DataCreationCharmReso.h Outdated Show resolved Hide resolved

vkucera reviewed Nov 28, 2025

View reviewed changes

PWGHF/D2H/Core/DataCreationCharmReso.h Outdated Show resolved Hide resolved

vkucera reviewed Nov 28, 2025

View reviewed changes

PWGHF/D2H/Core/DataCreationCharmReso.h Outdated Show resolved Hide resolved

fgrosa and others added 3 commits December 1, 2025 14:55

Merge branch 'master' of https://github.com/AliceO2Group/O2Physics in…

1f0dd84

…to reso

Factor out common code and simplify event selection

c11d6c7

Please consider the following formatting changes

4f93246

alibuild mentioned this pull request Dec 1, 2025

Please consider the following formatting changes to #14027 fgrosa/O2Physics#136

Merged

fgrosa and others added 3 commits December 1, 2025 18:59

Merge pull request #136 from alibuild/alibot-cleanup-14027

270c2c5

Please consider the following formatting changes to AliceO2Group#14027

Silence linter false positives

f2d7a9d

Please consider the following formatting changes

cf80ea2

alibuild mentioned this pull request Dec 1, 2025

Please consider the following formatting changes to #14027 fgrosa/O2Physics#137

Merged

Merge pull request #137 from alibuild/alibot-cleanup-14027

2619406

Please consider the following formatting changes to AliceO2Group#14027

vkucera reviewed Dec 1, 2025

View reviewed changes

PWGHF/D2H/Core/DataCreationCharmReso.h Outdated Show resolved Hide resolved

vkucera reviewed Dec 1, 2025

View reviewed changes

PWGHF/D2H/Core/DataCreationCharmReso.h Outdated Show resolved Hide resolved

vkucera reviewed Dec 1, 2025

View reviewed changes

PWGHF/D2H/Core/DataCreationCharmReso.h Outdated Show resolved Hide resolved

vkucera reviewed Dec 1, 2025

View reviewed changes

PWGHF/D2H/Core/DataCreationCharmReso.h Show resolved Hide resolved

vkucera reviewed Dec 1, 2025

View reviewed changes

PWGHF/D2H/Core/DataCreationCharmReso.h Outdated Show resolved Hide resolved

Implement Vit's comments

4cd7bb9

fgrosa marked this pull request as ready for review December 2, 2025 13:06

fgrosa requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, gluparel, hahassan7, jpxrk, mfaggin, mmazzilli, stefanopolitano and zhangbiao-phy as code owners December 2, 2025 13:06

Make linter happy also for warnings

7ea0caf

Make linter happy also for warnings

27b13d0

Fix typo

bc1cc43

fgrosa enabled auto-merge (squash) December 2, 2025 16:21

alibuild approved these changes Dec 2, 2025

View reviewed changes

fgrosa merged commit 2e1908a into AliceO2Group:master Dec 2, 2025
13 checks passed

[PWGHF] Refactory of charm reso derived data creator to improve compilation time #14027

[PWGHF] Refactory of charm reso derived data creator to improve compilation time #14027

Uh oh!

Conversation

fgrosa commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fgrosa commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

vkucera Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fgrosa commented Dec 2, 2025

Uh oh!

vkucera commented Dec 2, 2025

Uh oh!

fgrosa commented Dec 2, 2025

Uh oh!

vkucera commented Dec 2, 2025

Uh oh!

alibuild commented Dec 2, 2025

Uh oh!

alibuild left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 28, 2025 •

edited

Loading

vkucera commented Nov 28, 2025 •

edited

Loading

fgrosa commented Dec 1, 2025 •

edited

Loading