Skip to content

Conversation

@lhusova
Copy link
Contributor

@lhusova lhusova commented Nov 28, 2025

fix the code for V0s

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

O2 linter results: ❌ 27 errors, ⚠️ 21 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title ALICE3: Change in onTheFlyTracker.cxx [ALICE3] Change in onTheFlyTracker.cxx Nov 28, 2025
@alibuild
Copy link
Collaborator

alibuild commented Nov 28, 2025

Error while checking build/O2Physics/o2 for e8c8e31 at 2025-12-01 07:06:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14015-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:809:33: internal compiler error: in tsubst_expr, at cp/pt.cc:21462
ninja: build stopped: subcommand failed.

Full log here.

return foundNewCfg;
};

for (int icfg = 0; icfg < static_cast<int>(fastTrackerSettings.alice3geo->size()); ++icfg) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lhusova! I think that this could be problematic for analyses that does not use the fastTracker such as the D0 and Lc. Maybe we could instead use the size of the lut vectors for the primary particles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jesgum, probably it would be the best to do two separate loops? for Secondaries I don't need LUTs and it make sense to me that the loop goes over the different geometries. If you think that for the primaries LUTs loop would be better, then this would be an option. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lhusova, I think that doing it as two loops would be OK. One just needs to be careful such that the index matches between the loop for the primaries and the secondaries.
Because in my analysis for example, I use both, so it's important for me that one index points to the same geometry in both cases so I don't use one geometry for primaries and a different one for secondaries

The process function would also have to be adjusted similarly then I think onTheFlyTracker.cxx#L1544

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jesgum, please have a look how I solved it. I don't think that the line 1544 needs a change as the smearer is created as many times as this loop.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @lhusova!

@vkucera
Copy link
Collaborator

vkucera commented Dec 2, 2025

@lhusova The PR title doesn't say anything about what was done.

@njacazio njacazio changed the title [ALICE3] Change in onTheFlyTracker.cxx [ALICE3] Update V0 reconstruction in onTheFlyTracker Dec 3, 2025
Copy link
Collaborator

@njacazio njacazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhusova

@njacazio njacazio enabled auto-merge (squash) December 3, 2025 14:25
@njacazio njacazio merged commit 758be51 into AliceO2Group:master Dec 3, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants