-
Notifications
You must be signed in to change notification settings - Fork 613
[ALICE3] Update V0 reconstruction in onTheFlyTracker #14015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 27 errors, |
|
Error while checking build/O2Physics/o2 for e8c8e31 at 2025-12-01 07:06: Full log here. |
| return foundNewCfg; | ||
| }; | ||
|
|
||
| for (int icfg = 0; icfg < static_cast<int>(fastTrackerSettings.alice3geo->size()); ++icfg) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lhusova! I think that this could be problematic for analyses that does not use the fastTracker such as the D0 and Lc. Maybe we could instead use the size of the lut vectors for the primary particles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jesgum, probably it would be the best to do two separate loops? for Secondaries I don't need LUTs and it make sense to me that the loop goes over the different geometries. If you think that for the primaries LUTs loop would be better, then this would be an option. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lhusova, I think that doing it as two loops would be OK. One just needs to be careful such that the index matches between the loop for the primaries and the secondaries.
Because in my analysis for example, I use both, so it's important for me that one index points to the same geometry in both cases so I don't use one geometry for primaries and a different one for secondaries
The process function would also have to be adjusted similarly then I think onTheFlyTracker.cxx#L1544
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jesgum, please have a look how I solved it. I don't think that the line 1544 needs a change as the smearer is created as many times as this loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @lhusova!
|
@lhusova The PR title doesn't say anything about what was done. |
njacazio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lhusova
fix the code for V0s