[PWGHF] taskLc: do not repeat code in cases FillMl = true and false #14014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubynets
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
github-actions
bot
changed the title
|
O2 linter results: ❌ 0 errors, |
stefanopolitano
approved these changes
Dec 1, 2025
Collaborator
stefanopolitano
left a comment
stefanopolitano
left a comment
There was a problem hiding this comment.
Hi @lubynets ! Thanks for the development. I don't have any comments
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of
taskLc.cxxwhenTHnSparseis filled in two different conditions - with and without ML variables - the part of code unrelated to ML (occupancy and lifetime) is repeated. It is not so critical, but creates conditions for further code repetition during workflow development. The PR fixes this shortcoming.Tagging @Rrantu