Skip to content

Conversation

@fcatalan92
Copy link
Collaborator

@stefanopolitano @zhangbiao-phy @fgrosa I noticed that the zorro summary was not saved in the AnalysisResults.root files, I guess because the OutputObj needs to be defined in the actual task and it is not enough to have it in utilsEvSelHf.h. With this fix it works correctly.

image

@github-actions
Copy link

O2 linter results: ❌ 1 errors, ⚠️ 4 warnings, 🔕 16 disabled

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for a05b020 at 2025-11-28 04:09:

[353/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-Forwarding.dir/test/test_Forwarding.cxx.o
[354/4670] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/runDataProcessing.cxx.o
[355/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-ParallelProducer.dir/test/test_ParallelProducer.cxx.o
[356/4670] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-root.dir/test/test_Root2ArrowTable.cxx.o
[357/4670] Building CXX object Framework/Core/CMakeFiles/O2bench-framework-benchmark-ExternalFairMQDeviceProxies.dir/test/benchmark_ExternalFairMQDeviceProxies.cxx.o
[358/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-SimpleDataProcessingDevice01.dir/test/test_SimpleDataProcessingDevice01.cxx.o
[359/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-SimpleTimer.dir/test/test_SimpleTimer.cxx.o
[360/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-SimpleStringProcessing.dir/test/test_SimpleStringProcessing.cxx.o
[361/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-ParallelPipeline.dir/test/test_ParallelPipeline.cxx.o
[362/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-SimpleStatefulProcessing01.dir/test/test_SimpleStatefulProcessing01.cxx.o
[363/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-SimpleWildcard02.dir/test/test_SimpleWildcard02.cxx.o
[364/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-SlowConsumer.dir/test/test_SlowConsumer.cxx.o
[365/4670] Building CXX object Framework/AnalysisSupport/CMakeFiles/O2lib-FrameworkOnDemandTablesSupport.dir/src/OnDemandPlugin.cxx.o
[366/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-SimpleWildcard.dir/test/test_SimpleWildcard.cxx.o
[367/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-SlowProducerWithWildCard.dir/test/test_SlowProducerWithWildCard.cxx.o
[368/4670] Linking CXX shared library stage/lib64/libO2Framework.so
[369/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-SingleDataSource.dir/test/test_SingleDataSource.cxx.o
[370/4670] Building CXX object Framework/Core/CMakeFiles/O2bench-framework-benchmark-ASoA.dir/test/benchmark_ASoA.cxx.o
[371/4670] Linking CXX executable stage/tests/o2-test-framework-AlgorithmWrapper
[372/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-StaggeringWorkflow.dir/test/test_StaggeringWorkflow.cxx.o
[373/4670] Linking CXX executable stage/tests/o2-test-framework-Timers
[374/4670] Linking CXX executable stage/bin/o2-framework-ao2d-to-ao3d
[375/4670] Linking CXX executable stage/bin/o2-test-framework-ConsumeWhenAllOrdered
[376/4670] Linking CXX executable stage/tests/o2-test-framework-SuppressionGenerator
[377/4670] Linking CXX executable stage/bin/o2-framework-crashing-workflow
[378/4670] Linking CXX executable stage/tests/o2-test-framework-root
[379/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-DataAllocator.dir/test/test_DataAllocator.cxx.o
[380/4670] Linking CXX executable stage/tests/o2-test-framework-infologger
[381/4670] Linking CXX executable stage/bin/o2-dpl-run
[382/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-ProcessorOptions.dir/test/test_ProcessorOptions.cxx.o
[383/4670] Linking CXX executable stage/bin/o2-dpl-null-sink
[384/4670] Linking CXX executable stage/bin/o2-bench-framework-benchmark-DataDescriptorMatcher
[385/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-Task.dir/test/test_Task.cxx.o
[386/4670] Linking CXX executable stage/bin/o2-bench-framework-benchmark-DataRelayer
[387/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-DataDescriptorMatcherWorkflow.dir/test/test_DataDescriptorMatcherWorkflow.cxx.o
[388/4670] Linking CXX executable stage/bin/o2-bench-framework-benchmark-Stack
[389/4670] Linking CXX executable stage/bin/o2-bench-framework-benchmark-DeviceMetricsInfo
[390/4670] Linking CXX executable stage/bin/o2-bench-framework-benchmark-ASoA
[391/4670] Linking CXX executable stage/bin/o2-bench-framework-benchmark-InputRecord
[392/4670] Linking CXX executable stage/bin/o2-bench-framework-benchmark-WorkflowHelpers
[393/4670] Linking CXX executable stage/bin/o2-bench-framework-benchmark-ExternalFairMQDeviceProxies
[394/4670] Linking CXX executable stage/bin/o2-bench-framework-benchmark-HistogramRegistry
[395/4670] Linking CXX executable stage/bin/o2-bench-framework-benchmark-TableBuilder
[396/4670] Linking CXX executable stage/tests/o2-test-framework-CallbackService
[397/4670] Linking CXX executable stage/tests/o2-test-framework-RegionInfoCallbackService
[398/4670] Building CXX object Framework/Core/CMakeFiles/O2test-framework-VariablePayloadSequenceWorkflow.dir/test/test_VariablePayloadSequenceWorkflow.cxx.o
[399/4670] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_AnalysisTask.cxx.o
[400/4670] Linking CXX executable stage/tests/o2-test-framework-DataAllocator
[401/4670] Linking CXX executable stage/tests/o2-test-framework-DanglingOutputs
[402/4670] Linking CXX executable stage/tests/o2-test-framework-DanglingInputs

Full log here.

@fgrosa
Copy link
Collaborator

fgrosa commented Nov 28, 2025

@stefanopolitano @zhangbiao-phy @fgrosa I noticed that the zorro summary was not saved in the AnalysisResults.root files, I guess because the OutputObj needs to be defined in the actual task and it is not enough to have it in utilsEvSelHf.h. With this fix it works correctly.
image

Hi @fcatalan92 indeed, in the past I was looking for a solution different from defining the OutputObj<ZorroSummary> in all the tasks that use the HF event selection, so if you need it and you don't have a better solution, it's fine for me to add it.

@fgrosa fgrosa merged commit b8282e3 into AliceO2Group:master Nov 28, 2025
11 of 13 checks passed
yakparo pushed a commit to yakparo/O2Physics that referenced this pull request Nov 29, 2025
@fcatalan92
Copy link
Collaborator Author

Hi @fcatalan92 indeed, in the past I was looking for a solution different from defining the OutputObj<ZorroSummary> in all the tasks that use the HF event selection, so if you need it and you don't have a better solution, it's fine for me to add it.

Thanks, indeed I do not have a better solution for the moment. I will have a look and update the code in case I find something cleaner.

lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants