[PWGHF] add more UPC infos in taskLc.cxx #14007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
lubynets
reviewed
Nov 27, 2025
PWGHF/D2H/Tasks/taskLc.cxx
Outdated
| } | ||
| if (FT0A > FT0AThreshold && FT0C < FT0CThreshold && ZNA > ZDCThreshold && ZNC < ZDCThreshold) { | ||
| return GapType::GapC; | ||
| if (candidate.isSelLcToPKPi() >= selectionFlagLc) { |
Contributor
There was a problem hiding this comment.
Dear @Rrantu, can you please consider not duplicating the code but usage of already existing fillHistosData() (modifying it to UPC needs) function? Because now there are two big blocks of code, where one is a subset of another (with an extension related to UPC).
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. I thought about using fillHistosData(), but I need some non-global detector info that fillHistosData() doesn’t have and that isn’t useful for other analyses using it.
Collaborator
There was a problem hiding this comment.
Hi @lubynets, good suggestion! yes, we can remove it since we only need ThnSparse to store the key informations
Rrantu
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
stefanopolitano and
vkucera
as code owners
zhangbiao-phy
approved these changes
Nov 28, 2025
yakparo
pushed a commit
to yakparo/O2Physics
that referenced
this pull request
Nov 29, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FT0A, FT0C, FV0A, FDDA, FDDC, ZDC amplitudes and gap type axes to THnSparse in UPC runAnalysis function