-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGJE] adding reduced tables for tracks, particles, collisions, mccollisions #13991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
O2 linter results: ❌ 1 errors, |
|
Dear @louisemillot |
|
Dear @mhemmer-cern |
|
Hi, All errors come from existing workflow names in PWGJE/TableProducer/CMakeLists.txt, unrelated to this PR. |
|
Hi I am not sure how this builds locally as you are trying to include subscriptions to tables that the task produces itself. The logic is completely wrong, as you are not subscribing to tables that have those columns in them. Also the functionality of producing derived data already exists in the JE framework. It is of course fine if you want to write a task that further reduces the data but you should start with the JE derived data and reduce from there. This avoids running on the full dataset (unless there is a good reason to do so) |
|
Hi @louisemillot ,
That's a very low standard to claim that your code works. Follow the contribution guidelines before you make a PR and when you do, make it clear what your goal is, not just what you did. |
PWGJE: add tacks, particles, collisions, mccollisions tables and producer
Description:
Add AOD::SlimTracks with collision index and kinematic columns (pt, eta, phi, dcaXY)
Add AOD::SlimCollisions with posZ, centFT0M, weight, ...
AOD::SlimMcCollisions with posZ, centFT0M, weight, accepted, ptHard
AOD::SlimParticles with Mccollision index and kinematic columns (pt, eta, Px, ... etc )
Implement SlimTablesProducer to fill these tables from input AOD
Add PROCESS_SWITCH for each processing method
Test: