Skip to content

Conversation

@fgrosa
Copy link
Collaborator

@fgrosa fgrosa commented Nov 26, 2025

@zhangbiao-phy I moved the irSource configurable in the utilsEvSelHf.h to have it in the same configurable group as all the other configurables related to the event selection (also to avoid its redefinition in each creator)

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 15 disabled

@github-actions github-actions bot changed the title Move configurable belonging to HF event selection in proper struct [PWGHF] Move configurable belonging to HF event selection in proper struct Nov 26, 2025
@zhangbiao-phy
Copy link
Collaborator

@zhangbiao-phy I moved the irSource configurable in the utilsEvSelHf.h to have it in the same configurable group as all the other configurables related to the event selection (also to avoid its redefinition in each creator)

Thank you so much!

@fgrosa fgrosa enabled auto-merge (squash) November 26, 2025 11:16
zhangbiao-phy
zhangbiao-phy previously approved these changes Nov 26, 2025
alibuild
alibuild previously approved these changes Nov 26, 2025
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @fgrosa.

@fgrosa fgrosa dismissed stale reviews from alibuild and zhangbiao-phy via bc30fb9 November 26, 2025 11:34
@vkucera
Copy link
Collaborator

vkucera commented Nov 26, 2025

Good one! Thanks @fgrosa 👍🏻

@fgrosa fgrosa disabled auto-merge November 26, 2025 13:13
@fgrosa fgrosa enabled auto-merge (squash) November 26, 2025 13:13
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @fgrosa.

@fgrosa fgrosa merged commit aba466f into AliceO2Group:master Nov 26, 2025
22 checks passed
yakparo pushed a commit to yakparo/O2Physics that referenced this pull request Nov 29, 2025
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

4 participants