Skip to content

[PWGHF] Change histogram range for ItsChi2NCls in treeCreatorXic0ToXiPiKf.cxx #13966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkucera merged 1 commit into from
Dec 1, 2025
Merged

[PWGHF] Change histogram range for ItsChi2NCls in treeCreatorXic0ToXiPiKf.cxx #13966

vkucera merged 1 commit into from
Dec 1, 2025

Conversation

@Tao-Fang
Copy link
Contributor

@Tao-Fang Tao-Fang commented Nov 25, 2025

Updated histogram range for various Chi2NCls histograms from 0 to 10 to be -5.0 to 5.0.

@Tao-Fang
Change histogram range for Chi2NCls
97e7e8d 
Updated histogram range for various Chi2NCls histograms from 0 to 10 to be -5.0 to 5.0.
@github-actions github-actions bot added the pwghf PWG-HF label Nov 25, 2025
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Change histogram range for Chi2NCls [PWGHF] Change histogram range for Chi2NCls Nov 25, 2025
@Tao-Fang Tao-Fang changed the title [PWGHF] Change histogram range for Chi2NCls [PWGHF] Change histogram range for ItsChi2NCls Nov 25, 2025
@Tao-Fang Tao-Fang marked this pull request as ready for review November 25, 2025 12:30
@vkucera
Copy link
Collaborator

vkucera commented Nov 25, 2025 •
edited
Loading

Please consider using a configurable axis if you anticipate further binning adjustments.
Please add the location of your changes in the PR title.

@Tao-Fang Tao-Fang changed the title [PWGHF] Change histogram range for ItsChi2NCls [PWGHF] Change histogram range for ItsChi2NCls treeCreatorXic0ToXiPiKf.cxx Nov 25, 2025
@Tao-Fang Tao-Fang changed the title [PWGHF] Change histogram range for ItsChi2NCls treeCreatorXic0ToXiPiKf.cxx [PWGHF] Change histogram range for ItsChi2NCls in treeCreatorXic0ToXiPiKf.cxx Nov 25, 2025
@Tao-Fang
Copy link
Contributor Author

Tao-Fang commented Nov 25, 2025

Please consider using a configurable axis if you anticipate further binning adjustments.

Thanks your comment, as far as i know this axis is not expected to change in future.

@alibuild
Copy link
Collaborator

alibuild commented Nov 28, 2025

Error while checking build/O2Physics/o2 for 97e7e8d at 2025-11-28 19:39:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
[0 more errors; see full log]

Full log here.

@Tao-Fang
Copy link
Contributor Author

Tao-Fang commented Nov 30, 2025

Please consider using a configurable axis if you anticipate further binning adjustments. Please add the location of your changes in the PR title.

Hi Vit, would you mind approving this? Thank you

@vkucera vkucera merged commit 8019d0e into AliceO2Group:master Dec 1, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tao-Fang @vkucera @alibuild