Skip to content

Conversation

@yhambard
Copy link
Contributor

added multiple histos that get filled with mc true electron information for purity and efficiency calculations
added TOF signal histograms
fixed broken logic, added histograms for pid quality checks refactored some code

added multiple histos that get filled with mc true electron information for purity and efficiency calculations
added TOF signal histograms
fixed broken logic, added histograms for pid quality checks
refactored some code
@github-actions github-actions bot added the pwgem label Nov 24, 2025
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title more efficiency and purity histograms phosElId.cxx [PWGEM] more efficiency and purity histograms phosElId.cxx Nov 24, 2025
@yhambard yhambard marked this pull request as ready for review November 24, 2025 03:13
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 1a106b4 at 2025-11-24 05:54:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13943-slc9_x86-64/0/PWGEM/Tasks/phosElId.cxx:1377:39: error: comparison of integer expressions of different signedness: 'int' and 'std::size_t' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/13943-slc9_x86-64/0/PWGEM/Tasks/phosElId.cxx:1394:25: error: comparison of integer expressions of different signedness: 'int' and 'std::size_t' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

'int' and 'std::size_t' were being compared when creating histograms
@yhambard
Copy link
Contributor Author

Could I get a review to merge, please? @alibuild @ivorobye @dsekihat @feisenhu

@dsekihat dsekihat merged commit f7cac5d into AliceO2Group:master Nov 24, 2025
12 checks passed
yakparo pushed a commit to yakparo/O2Physics that referenced this pull request Nov 29, 2025
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants