Skip to content

[PWGEM/Dilepton] add a task for polarization #13942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsekihat merged 2 commits into from
Nov 24, 2025
Merged

[PWGEM/Dilepton] add a task for polarization #13942

dsekihat merged 2 commits into from
Nov 24, 2025

Conversation

@dsekihat
Copy link
Collaborator

@dsekihat dsekihat commented Nov 23, 2025

PWGEM/Dilepton: add a task for polarization

@github-actions
Copy link

github-actions bot commented Nov 23, 2025 •
edited
Loading

O2 linter results: ❌ 278 errors, ⚠️ 240 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title PWGEM/Dilepton: add a task for polarization [PWGEM/Dilepton] add a task for polarization Nov 23, 2025
@dsekihat dsekihat enabled auto-merge (squash) November 23, 2025 22:01
alibuild
alibuild previously approved these changes Nov 23, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@alibuild
Copy link
Collaborator

alibuild commented Nov 23, 2025

Error while checking build/O2Physics/o2 for ced631e at 2025-11-23 23:34:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13942-slc9_x86-64/0/PWGEM/Dilepton/Core/DileptonProducer.h:583:13: error: unused variable 'centrality' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/13942-slc9_x86-64/0/PWGEM/Dilepton/Core/DileptonProducer.h:511:33: error: variable 'v12' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/13942-slc9_x86-64/0/PWGEM/Dilepton/Core/DileptonProducer.h:469:39: error: unused parameter 'collision' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/13942-slc9_x86-64/0/PWGEM/Dilepton/Core/DileptonProducer.h:583:13: error: unused variable 'centrality' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/13942-slc9_x86-64/0/PWGEM/Dilepton/Core/DileptonProducer.h:511:33: error: variable 'v12' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/13942-slc9_x86-64/0/PWGEM/Dilepton/Core/DileptonProducer.h:469:39: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@dsekihat dsekihat disabled auto-merge November 24, 2025 00:43
@dsekihat
Comment out unused code in DileptonProducer.h
8c6212d 
Commented out unused code related to centrality and vector addition.
@dsekihat dsekihat enabled auto-merge (squash) November 24, 2025 09:35
alibuild
alibuild approved these changes Nov 24, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat merged commit bc00ec9 into AliceO2Group:master Nov 24, 2025
10 of 12 checks passed
@dsekihat dsekihat deleted the polmix branch November 24, 2025 09:35
vkucera
vkucera reviewed Nov 25, 2025
View reviewed changes
PWGEM/Dilepton/Core/DileptonProducer.h
#include <vector>

using namespace o2;
using namespace o2::aod;
Copy link
Collaborator

@vkucera vkucera Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsekihat Do not add new errors.

yakparo pushed a commit to yakparo/O2Physics that referenced this pull request Nov 29, 2025
@dsekihat @yakparo
[PWGEM/Dilepton] add a task for polarization (AliceO2Group#13942)
a44c17a
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@dsekihat
[PWGEM/Dilepton] add a task for polarization (AliceO2Group#13942)
5d0941d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@alibuild alibuild alibuild approved these changes

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@ivorobye ivorobye Awaiting requested review from ivorobye ivorobye is a code owner

@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

Assignees

No one assigned

Labels

datamodel pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsekihat @alibuild @vkucera