Skip to content

[PWGHF] Tasks D0, D+: Minor fix for UPC processes #13941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkucera merged 7 commits into from
Nov 23, 2025
Merged

[PWGHF] Tasks D0, D+: Minor fix for UPC processes #13941

vkucera merged 7 commits into from
Nov 23, 2025

Conversation

@minjungkim12
Copy link
Contributor

@minjungkim12 minjungkim12 commented Nov 23, 2025 •
edited
Loading

Minor bug fix for d0/dplus UPC analyses:

  1. Add the doprocess boolean (doprocessDataWithUpc) into the if statement used for defining THnSparse.
  2. Move two histograms out from the if statement requiring has_zdc in taskDplus and taskD0.
  3. Remove the usage of "isSingleSidedGap" in taskDplus and taskD0 as it is not necessary.

@github-actions github-actions bot added the pwghf PWG-HF label Nov 23, 2025
@github-actions github-actions bot changed the title minor fix for UPC processes [PWGHF] minor fix for UPC processes Nov 23, 2025
@github-actions
Copy link

github-actions bot commented Nov 23, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Nov 23, 2025
Merged
@minjungkim12
Merge pull request #4 from alibuild/alibot-cleanup-13941
a41c16a 
Please consider the following formatting changes to AliceO2Group#13941
@minjungkim12 minjungkim12 marked this pull request as ready for review November 23, 2025 14:10
jpxrk
jpxrk previously approved these changes Nov 23, 2025
View reviewed changes
@jpxrk jpxrk enabled auto-merge (squash) November 23, 2025 14:15
vkucera
vkucera reviewed Nov 23, 2025
View reviewed changes
@minjungkim12 minjungkim12 marked this pull request as draft November 23, 2025 14:38
auto-merge was automatically disabled November 23, 2025 14:38

Pull request was converted to draft

@alibuild alibuild mentioned this pull request Nov 23, 2025
Merged
@minjungkim12
Merge pull request #5 from alibuild/alibot-cleanup-13941
032dd1b 
Please consider the following formatting changes to AliceO2Group#13941
@minjungkim12 minjungkim12 marked this pull request as ready for review November 23, 2025 14:47
@minjungkim12 minjungkim12 requested a review from vkucera November 23, 2025 14:47
@vkucera vkucera changed the title [PWGHF] minor fix for UPC processes [PWGHF] Tasks D0, D+: Minor fix for UPC processes Nov 23, 2025
@vkucera vkucera merged commit dc2fde9 into AliceO2Group:master Nov 23, 2025
18 checks passed
yakparo pushed a commit to yakparo/O2Physics that referenced this pull request Nov 29, 2025
@minjungkim12 @alibuild @yakparo
[PWGHF] Tasks D0, D+: Minor fix for UPC processes (AliceO2Group#13941)
50fabbf 
Co-authored-by: minjungkim12 <minjungkim12@users.noreply.github.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@minjungkim12 @alibuild
[PWGHF] Tasks D0, D+: Minor fix for UPC processes (AliceO2Group#13941)
2381a35 
Co-authored-by: minjungkim12 <minjungkim12@users.noreply.github.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@jpxrk jpxrk jpxrk left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@minjungkim12 @vkucera @jpxrk @alibuild