Skip to content

Conversation

@jaimenorman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pwgje label Nov 21, 2025
@github-actions github-actions bot changed the title add additional checks on accepted and rejected tracks [PWGJE] add additional checks on accepted and rejected tracks Nov 21, 2025
@github-actions
Copy link

O2 linter results: ❌ 14 errors, ⚠️ 10 warnings, 🔕 2 disabled

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 2af6f3a at 2025-11-21 23:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13931-slc9_x86-64/0/PWGJE/Tasks/jetOutlierQA.cxx:692:15: error: unused variable 'mcCollisionIDcoll' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/13931-slc9_x86-64/0/PWGJE/Tasks/jetOutlierQA.cxx:693:15: error: unused variable 'mcCollisionIDOutlier' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft November 24, 2025 20:52
@vkucera
Copy link
Collaborator

vkucera commented Nov 24, 2025

@jaimenorman Please always make sure your branch compiles without warnings and that it's properly formatted before opening the PR for review.

@jaimenorman
Copy link
Contributor Author

@jaimenorman Please always make sure your branch compiles without warnings and that it's properly formatted before opening the PR for review.

sorry, indeed it compiled locally so didn't pick up on the mistake. I've opened a new PR ( #14001 ), so close this one

@vkucera
Copy link
Collaborator

vkucera commented Nov 27, 2025

@jaimenorman Please always make sure your branch compiles without warnings and that it's properly formatted before opening the PR for review.

sorry, indeed it compiled locally so didn't pick up on the mistake. I've opened a new PR ( #14001 ), so close this one

Why did you not just update this PR instead?

@jaimenorman
Copy link
Contributor Author

@jaimenorman Please always make sure your branch compiles without warnings and that it's properly formatted before opening the PR for review.

sorry, indeed it compiled locally so didn't pick up on the mistake. I've opened a new PR ( #14001 ), so close this one

Why did you not just update this PR instead?

I had made some additional changes to the task in the meantime - I thought it would be cleaner to push both together so I did this in a new PR

@vkucera
Copy link
Collaborator

vkucera commented Nov 27, 2025

@jaimenorman Please always make sure your branch compiles without warnings and that it's properly formatted before opening the PR for review.

sorry, indeed it compiled locally so didn't pick up on the mistake. I've opened a new PR ( #14001 ), so close this one

Why did you not just update this PR instead?

I had made some additional changes to the task in the meantime - I thought it would be cleaner to push both together so I did this in a new PR

I actually doesn't have any benefits to replace a PR with another one. It will just run all tests from scratch which might be unnecessary. You can modify all properties of the PR (title, description, commits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants