Skip to content

[Common,PWGCF,PWGDQ,PWGEM,PWGHF,PWGJE,PWGLF,PWGUD] Fix dictionary for Zorro objects #13917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktf merged 5 commits into from
Nov 25, 2025
Merged

[Common,PWGCF,PWGDQ,PWGEM,PWGHF,PWGJE,PWGLF,PWGUD] Fix dictionary for Zorro objects #13917

ktf merged 5 commits into from
Nov 25, 2025

Conversation

@fgrosa
Copy link
Collaborator

@fgrosa fgrosa commented Nov 21, 2025

This PR solves the issue with the Zorro library for CCDB objects. @ddobrigk could you please check if it looks good to you and merge it?
Pinging also @mpuccio for info.
Thanks a lot!

@github-actions github-actions bot changed the title Fix dictionary for Zorro objects [Common,PWGCF,PWGDQ,PWGEM,PWGHF,PWGJE,PWGLF,PWGUD] Fix dictionary for Zorro objects Nov 21, 2025
@github-actions
Copy link

github-actions bot commented Nov 21, 2025 •
edited
Loading

O2 linter results: ❌ 18 errors, ⚠️ 3 warnings, 🔕 0 disabled

rolavick
rolavick previously approved these changes Nov 21, 2025
View reviewed changes
romainschotter
romainschotter previously approved these changes Nov 21, 2025
View reviewed changes
ddobrigk
ddobrigk previously approved these changes Nov 21, 2025
View reviewed changes
Copy link
Collaborator

@ddobrigk ddobrigk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @fgrosa !

@fgrosa fgrosa dismissed stale reviews from ddobrigk and romainschotter via a6e1f13 November 21, 2025 12:28
@fgrosa fgrosa marked this pull request as draft November 21, 2025 16:44
nzardosh
nzardosh previously approved these changes Nov 21, 2025
View reviewed changes
@fgrosa fgrosa marked this pull request as ready for review November 24, 2025 08:08
@alibuild
Copy link
Collaborator

alibuild commented Nov 24, 2025 •
edited
Loading

Error while checking build/O2Physics/o2 for 662eb32 at 2025-11-24 19:35:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
[0 more errors; see full log]

Full log here.

amatyja
amatyja previously approved these changes Nov 24, 2025
View reviewed changes
Copy link
Collaborator

@amatyja amatyja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine with UD. Thanks for improvements.

ddobrigk
ddobrigk previously approved these changes Nov 24, 2025
View reviewed changes
@fgrosa fgrosa dismissed stale reviews from ddobrigk, amatyja, and nzardosh via 7660ae6 November 25, 2025 08:18
victor-gonzalez
victor-gonzalez approved these changes Nov 25, 2025
View reviewed changes
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK from PWGCF!
Thanks @fgrosa!!

@ddobrigk ddobrigk enabled auto-merge (squash) November 25, 2025 10:53
@ktf ktf merged commit 191944d into AliceO2Group:master Nov 25, 2025
19 of 24 checks passed
yakparo pushed a commit to yakparo/O2Physics that referenced this pull request Nov 29, 2025
@fgrosa @yakparo
[Common,PWGCF,PWGDQ,PWGEM,PWGHF,PWGJE,PWGLF,PWGUD] Fix dictionary for…
4964d8b 
… Zorro objects (AliceO2Group#13917)
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@fgrosa
[Common,PWGCF,PWGDQ,PWGEM,PWGHF,PWGJE,PWGLF,PWGUD] Fix dictionary for…
5bca700 
… Zorro objects (AliceO2Group#13917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@mpuccio mpuccio mpuccio approved these changes

@romainschotter romainschotter romainschotter approved these changes

@rolavick rolavick rolavick left review comments

@amatyja amatyja amatyja left review comments

@nzardosh nzardosh nzardosh left review comments

@ddobrigk ddobrigk ddobrigk left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

@ivorobye ivorobye Awaiting requested review from ivorobye ivorobye is a code owner

@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner

@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

common pwgcf pwgdq pwgem pwghf PWG-HF pwgje pwglf pwgud

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@fgrosa @alibuild @victor-gonzalez @mpuccio @rolavick @amatyja @nzardosh @ddobrigk @romainschotter @ktf